Zinble is a fully Responsive Drupal 8 theme built on the Bootstrap 4.x Framework.
Project link
https://www.drupal.org/project/zinble
Git instructions
git clone --branch 1.x https://git.drupalcode.org/project/zinble.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-zinble.git
Comments
Comment #2
ashutosh.mishra commentedComment #3
ashutosh.mishra commentedThank you for applying! I updated the Git instructions for non-maintainer users and also added PAReview checklist .
Comment #4
ashutosh.mishra commentedPlease fix below issue
8Mb
Comment #5
ashutosh.mishra commentedComment #6
ashutosh.mishra commentedComment #7
jimmy_sebastian commentedComment #8
avpadernoComment #9
avpadernoComment #10
jimmy_sebastian commentedComment #11
rohitrajputsahab commentedjs/custom.js
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] Inline comments must start with a capital letter
6 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
Comment #12
ankush_03Not find any issue in pareview.sh report
contrib % drupal-check -ad zinble
1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
Comment #13
avpadernoWhat reported in the previous comment has not been fixed, yet.
Comment #14
jimmy_sebastian commentedJS validation issues fixed. Ready for review.
Comment #15
shaktikHi jimmy_sebastian,
Thanks for your contribution.
No issue found in PAReview report and drupal-check.
Shakti-Kumar:d8 shakti.kumar$ vendor/bin/drupal-check -ad web/modules/contrib/zinble/
1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
Comment #16
jimmy_sebastian commented@shaktik, Thanks for the review.
Comment #17
klausiOtherwise looks good to me.
Thanks for your contribution, Jimmy!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #18
avpaderno