Zinble is a fully Responsive Drupal 8 theme built on the Bootstrap 4.x Framework.

Project link

https://www.drupal.org/project/zinble

Git instructions

git clone --branch 1.x https://git.drupalcode.org/project/zinble.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-zinble.git

Comments

jimmy_sebastian created an issue. See original summary.

ashutosh.mishra’s picture

Issue summary: View changes
ashutosh.mishra’s picture

Thank you for applying! I updated the Git instructions for non-maintainer users and also added PAReview checklist .

ashutosh.mishra’s picture

Please fix below issue

Review of the 1.x branch (commit 9893268):
Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.

FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/zinble.theme
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 51 | WARNING | #options values usually have to run through t() for
    |         | translation
 51 | WARNING | #options values usually have to run through t() for
    |         | translation
--------------------------------------------------------------------------

Time: 265ms; Memory: 4Mb
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/style.css
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
 143 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #ccc but found #CCC
 160 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #fff but found #FFF
 181 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #fff but found #FFF
 186 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #fff but found #FFF
 191 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #fff but found #FFF
 340 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #ccc but found #CCC
 493 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #ccc but found #CCC
 609 | ERROR | [x] CSS colours must be defined in lowercase; expected
     |       |     #ccc but found #CCC
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/print.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/zinble.theme
--------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 13 LINES
--------------------------------------------------------------------------
   1 | ERROR | [x] Missing file doc comment
  17 | ERROR | [x] Whitespace found at end of line
  40 | ERROR | [x] Namespaced classes/interfaces/traits should be
     |       |     referenced with use statements
  47 | ERROR | [x] Whitespace found at end of line
  51 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
  51 | ERROR | [x] Short array syntax must be used to define arrays
  51 | ERROR | [x] Comma not allowed after last value in single-line
     |       |     array declaration
  54 | ERROR | [x] Whitespace found at end of line
  60 | ERROR | [x] Whitespace found at end of line
  66 | ERROR | [x] Whitespace found at end of line
  72 | ERROR | [x] Whitespace found at end of line
  78 | ERROR | [x] Whitespace found at end of line
  84 | ERROR | [x] Whitespace found at end of line
 114 | ERROR | [x] Whitespace found at end of line
 115 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.15 secs; Memory: 

8Mb

ashutosh.mishra’s picture

Issue summary: View changes
ashutosh.mishra’s picture

Status: Needs review » Needs work
jimmy_sebastian’s picture

Assigned: Unassigned » jimmy_sebastian
avpaderno’s picture

Assigned: jimmy_sebastian » Unassigned
avpaderno’s picture

Title: [D8] - Zinble Drupal 8 Responsive Theme » [D8] Zinble Drupal 8 Responsive Theme
Issue summary: View changes
Issue tags: +PAreview: project created less than ten days ago
jimmy_sebastian’s picture

Status: Needs work » Needs review
rohitrajputsahab’s picture

Status: Needs review » Needs work

js/custom.js

FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] Inline comments must start with a capital letter
6 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses

ankush_03’s picture

Status: Needs work » Needs review

Not find any issue in pareview.sh report

contrib % drupal-check -ad zinble
1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

avpaderno’s picture

Status: Needs review » Needs work

What reported in the previous comment has not been fixed, yet.

jimmy_sebastian’s picture

Status: Needs work » Needs review

JS validation issues fixed. Ready for review.

shaktik’s picture

Hi jimmy_sebastian,

Thanks for your contribution.

No issue found in PAReview report and drupal-check.

Shakti-Kumar:d8 shakti.kumar$ vendor/bin/drupal-check -ad web/modules/contrib/zinble/
1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

jimmy_sebastian’s picture

@shaktik, Thanks for the review.

klausi’s picture

Status: Needs review » Fixed
  1. There is a file templates/blocks/block--views-block.html.twig7777, I think that should be removed
  2. The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722

Otherwise looks good to me.

Thanks for your contribution, Jimmy!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

avpaderno’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.