[D8] Fullcalendar View

Thank you for your contribution! Reviewers will check the code and report here what they found out.

8.x-2.0 is a wrong branch name. The branch should be removed.

Review of the 8.x-2.x branch (commit 243fdaa):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...p/modules/calendar_recurring_event/calendar_recurring_event.info.yml
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   8 | WARNING | All dependencies must be prefixed with the project name,
     |         | for example "drupal:"
  --------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

js folder: why do you need all the JS libraries here when you load them remotely in fullcalendar_view.libraries.yml?
CalendarEventController: this is vulnerable to CSRF exploits. You are saving entities without a form and without checking a CSRF token. So I think in template_preprocess_views_view_fullcalendar() you have to add a CSRF token that you then need to verify in the controller. CsrfTokenGenerator service can create and validate that for you.
"$this->loggerFactory->get('content')->notice($entity->getType() . ': updated ' . $entity->getTitle());": do not concatenate variables into log messages, use placeholders instead.
"return new Response($entity->getTitle() . ' is updated to from ' . $start_date . ' to ' . $end_date);": all user facing text must run through the Drupal translation system, and you should use placeholders for the variables.

And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Looks good now, thanks!

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.