[D7] Search Index Options

Hi AltaGrade,

See the automated Pareview of your project

https://pareview.sh/pareview/https-git.drupal.org-project-search_index.git

You should also edit the issue summary and add the correct git clone command for your project:

git clone --branch 7.x-2.x https://git.drupal.org/project/search_index.git

There is also standard for modules to remove any data they create when uninstalled. For instance you should remove the
variable 'search_content_types' when your module is uninstalled or perhaps this variable comes from the core search module?

I just installed the module in a clean installation where the core search module was initially disabled and when visiting `admin/config/search/settings` I get the following warning message:

* Notice: Undefined offset: 0 in search_index_form_alter() (line 32 of /var/www/html/d7/sites/all/modules/search_index/search_index.module).

Probably because the `search_active_modules` variable does not yet exists.

If I first disable the `search_index` module and then visiting the search configuration page and click save once, then enable `search_index` and visiting the same page then there is no error messages.

This behavior can be tested by simply delete the `search_active_modules` variable from the database.

Great that you solved the php notifications that I mentioned above. I think you should rename the variable search_content_types, prefixing it with the name of your module i.e search_index_content_types. This will make it easier for others to see which module created the variable. I am not sure if this is a standard, but in my opinion it really should be =)

If you look at other modules like syslog, search, simpletest you will see that the variable names almost always are prefixed with the actual name of the module. For instance:

simpletest_httpauth_method
simpletest_httpauth_username
simpletest_httpauth_password
simpletest_clear_results
simpletest_verbose
search_cron_limit
search_logging
syslog_identity
syslog_facility
syslog_format

When this is done I don't see any reason not to mark this as RTBC.

You should not mark your own issue as RTBC, but I was anyway suppose to do this now so I guess it does not matter =)

Feel free to assign any credit for the help in this process as per:
https://www.drupal.org/drupalorg/blog/a-guide-to-issue-credits-and-the-d...

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.