[D8] Roundabout Slider [#2946769]

Roundabout is a module for creating slideshows and carousel-like animations with help of a 3D Turntable jQuery Roundabout plugin. It easily converts unordered lists & other nested HTML structures into entertaining, interactive, turntable-like areas. This module currently works with views.

This project is in an early stage and doesn't support all options the js library provides. These will be added over time.

Features

Reflect
Autoplay on/off
Autoplay Initial Delay
Autoplay duration
Pause on hover on/off
Duration
jQuery Easing

Project link:
https://www.drupal.org/project/roundabout

Project Git url:
git clone --branch 8.x-1.x https://git.drupal.org/project/roundabout.git

Manual reviews of other projects
https://www.drupal.org/node/2946131#comment-12495092
https://www.drupal.org/node/2943337#comment-12495150
https://www.drupal.org/node/2938477#comment-12497166

Comment	File	Size	Author
#2	fixed_coding_standards-2946769-2.patch	9.74 KB	Deepthi kumari
#2	coding_standard_errors-2946769-2.txt	6.96 KB	Deepthi kumari

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 February 2018 at 07:42

ashish-deynap created an issue. See original summary.

Comment #2

Deepthi kumari CreditAttribution: Deepthi kumari at TA Digital commented 22 February 2018 at 09:53

Status:

Active

» Needs review

File	Size
coding_standard_errors-2946769-2.txt	6.96 KB
fixed_coding_standards-2946769-2.patch	9.74 KB

Hi,

Have found Coding Standard Errors in Coder Sniffer. Applied patch. Needs review.

Thankyou

Comment #3

ashish-deynap CreditAttribution: ashish-deynap at TO THE NEW commented 22 February 2018 at 10:43

Hi @Deepthi kumari,
Thanks for providing the patch. I have fixed those issues. Please review the updated code.

Comment #4

Deepthi kumari CreditAttribution: Deepthi kumari at TA Digital commented 22 February 2018 at 10:50

Status:

Needs review

» Reviewed & tested by the community

Hi,

It's working fine.

Can I get a credit :)

Comment #5

ashish-deynap CreditAttribution: ashish-deynap at TO THE NEW commented 23 February 2018 at 09:22

Yes, sure.

Comment #6

ashish-deynap CreditAttribution: ashish-deynap at TO THE NEW commented 26 February 2018 at 04:34

Issue summary:	View changes
Issue tags:		+PAreview: review bonus

Comment #7

deepali_agarwal CreditAttribution: deepali_agarwal commented 27 February 2018 at 06:06

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts.
No duplication: Yes: Does not cause module duplication and/or fragmentation.
Master Branch: Yes: Follows the guidelines for master branch.
Licensing: Yes: Follows the licensing requirements.
3rd party assets/code: Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md: Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review: Yes: Follows the guidelines for project length and complexity.
Secure code: Yes: Meets the security requirements.

This review uses the Project Application Review Template.

Module works very well with views. It provides awesome 3D slider. Looking forward to use it.

Comment #8

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha as a volunteer commented 27 February 2018 at 15:50

Issue tags:

-PAreview: review bonus

Hi Ashish,

First, Thanks for your contribution.
Please do the manual reviews of the code. If you didn't find anything during the code review mark the application as RTBC. I have seen your code reviews and none of them is showing manual reviews, so removing the Pareview bonus tag. Please do the three manual reviews.

Thanks!

Comment #9

rajveergangwar

English

Delhi

CreditAttribution: rajveergangwar as a volunteer and commented 28 February 2018 at 10:48

@ashish-deynap

in roundabout_help,
Please provide the detailed explanation and put library link, because if somebody installed module form ftp he won't be able to see README.txt SO its good to have in hook_help.

Comment #10

visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commented 5 March 2018 at 07:28

Status:

Reviewed & tested by the community

» Fixed

Thanks for your contribution, Ashish Pandey!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.