Hello,

Show title is our first contribued Drupal (8.x) module and we wanna receive security advisory coverage.

Description

This module creates an Extrafield (pseudo-fields) of native node title field for rendering and use in display mode.

Project Url

https://www.drupal.org/project/show_title

To clone the repo

git clone --branch 8.x-1.x https://git.drupal.org/project/show_title.git

Thanks for your review.

Comments

Guietc created an issue. See original summary.

Guietc’s picture

Guietc CreditAttribution: Guietc commented
Status: Active » Needs review
ashish-deynap’s picture

ashish-deynap CreditAttribution: ashish-deynap at TO THE NEW commented
Status: Needs review » Needs work

Automated Review

The show_title.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu...

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
README.md or README.txt is missing.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
The code follows the drupal coding standard.
Guietc’s picture

Guietc CreditAttribution: Guietc commented
Status: Needs work » Needs review

Thanks @ashish-deynap for your reply.
I added the hook_help() and the README.

RonanRBR’s picture

RonanRBR
Primary language Portuguese, Brazil
Location Fortaleza-CE
CreditAttribution: RonanRBR commented
Priority: Normal » Minor

Review of the 8.x-1.x branch (commit ac3f671):

  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Priority: Minor » Critical
sleitner’s picture

sleitner CreditAttribution: sleitner commented
Priority: Critical » Normal
Status: Needs review » Needs work

The name in the taxonomy terms is not shown in manage display list.

You have to use Drupal\taxonomy\Entity\Vocabulary (instead of Drupal\taxonomy\Entity\Term) to get the ids of the vocabularies.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.

Guietc’s picture

Guietc CreditAttribution: Guietc commented
Status: Closed (won't fix) » Needs review

The #7 issue has been fixed.

sleitner’s picture

sleitner CreditAttribution: sleitner commented
Status: Needs review » Reviewed & tested by the community

Automated Review

Review of the 8.x-1.x branch (commit 916e04a):

  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows / No: Does not follow] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
No issues.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.