FlipBook defines an custom entity type for view pdf files as Magazine or Book.
It uses Jquery libraries from code-canyon 3dflipbook with book effects and flip pages .
Features-

  • Provide a custom entity type call Flipbook. `
  • Display PDF pages with book effect.
  • Display the "book" over a colorbox frame.
  • Provide a Flipbook Display Setting for adding fields, managing display or form display.
  • Provide configuration which selects style of PDF display.
  • Provide integration with views.

Project URL:
https://www.drupal.org/project/flipbook

Git URL:
git clone --branch 8.x-1.x https://git.drupal.org/project/flipbook.git

CommentFileSizeAuthor
#4 coding_standard_errors.txt43.52 KBleymannx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kushal Bansal created an issue. See original summary.

Kushal Bansal’s picture

Kushal Bansal CreditAttribution: Kushal Bansal commented
Title: [D8]3D Flipbook » [D8] 3D Flipbook
Status: Active » Needs review
leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented
Issue summary: View changes
  • Added project URL.
  • Highlighted Git URL
leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented
FileSize
coding_standard_errors.txt43.52 KB

Code Sniffer found the following errors.

leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented

As of 4.2 of Security advisory coverage application checklist
- Remove 3rd party files or non-GPLv2+ material (css/bootstrap*.css, css/font-awesome.css, fonts/*, ) and add them via Composer instead

Twig
- templates/default-book-view.html should be *.html.twig

Coding Standards
- I strongly advise having a look at Drupal's Coding Standards.

leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented
Status: Needs review » Needs work
Kushal Bansal’s picture

Kushal Bansal CreditAttribution: Kushal Bansal commented

Hi leymann

I am working on Coding standards for this.In the upcoming versions of this it will be as per Coding standards you mentioned.

Kushal Bansal’s picture

Kushal Bansal CreditAttribution: Kushal Bansal commented

Thanks

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Needs review
sleitner’s picture

sleitner CreditAttribution: sleitner commented
Status: Needs review » Needs work

Automated Review

Pareview.sh does not load this module, may be because of the many *.min.js files.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
No: Does not follow the guidelines for 3rd party assets/code. Fontawesome and all 3rd party css and js libraries should live in /libraries/ . Under which license are the images?
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. REQUIREMENTS section required
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
  1. (*) I am not sure how to consider this application, since the project used to apply for being a vetted user has many commits from another user.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.

manish17’s picture

manish17 CreditAttribution: manish17 commented

how i add flipbook functionality as a field in a content type.
Thanks in advance.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Closed (won't fix) » Closed (duplicate)
Related issues: +#3163240: [D8] Webform Dynamic Autocomplete