[D8] jQCloud [#2938477]

Module for display taxonomy terms in blocks with integrated the jQCloud jQuery plugin.

Direct link to the module https://www.drupal.org/project/jqcloud

git clone --branch 8.x-1.x https://git.drupal.org/project/jqcloud.git

Comment	File	Size	Author
#3	jqcloud_coding_standard_errors.txt	4.14 KB	saivaishnavijupudi

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 January 2018 at 10:00

tibezh created an issue. See original summary.

Comment #2

jfs.csantos CreditAttribution: jfs.csantos as a volunteer and at Bynder commented 31 January 2018 at 10:37

All looking good, except for the issue I opened in the project page regarding using the module.

Comment #3

saivaishnavijupudi CreditAttribution: saivaishnavijupudi as a volunteer and at TA Digital commented 16 February 2018 at 13:56

File	Size
jqcloud_coding_standard_errors.txt	4.14 KB

I found the above phpcs coding standard errors

Comment #4

leymannx

he/him

German

Berlin

CreditAttribution: leymannx commented 16 February 2018 at 16:49

@saivaishnavijupudi – again your phpcs configuration produces lots of false positives. There must not be a file doc in every file ending with *.php. And even if it would be needed then there must be one blank line after the php opening tag. Please review your phpcs configuration.

Comment #5

ashish-deynap CreditAttribution: ashish-deynap at TO THE NEW commented 24 February 2018 at 16:35

Status:

Needs review

» Needs work

Automated Review

Git default branch is not set, see the documentation on setting a default branch.
The jqcloud_library_test.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
The jqcloud.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
ESLint has found some issues with /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/jqcloud.js: line 7, col 2, Error - Use the function form of 'use strict'.

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts.
No duplication: Yes: Does not cause module duplication and/or fragmentation.
Master Branch: Yes: Follows the guidelines for master branch.
Licensing: Yes: Follows the licensing requirements.
3rd party assets/code: Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md: README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
Code long/complex enough for review: Yes: Follows the guidelines for project length and complexity.
Secure code: Yes: Meets the security requirements.

Nice and clean module, Thanks for contributing to Drupal Community.

Comment #6

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 21 May 2018 at 07:09

Status:	Needs work	» Closed (duplicate)
Related issues:		+#2938480: [D8] Date Timepicker

Thank you for your contribution!

We just accept one application per user. Any application opened after the first one is closed settings its status to Closed (duplicate).
The purpose of these applications is not reviewing every project, but give users the vetted role, which allows them to change the status of their projects (the ones they already created or the ones they will create).