Applying for the opt-in to security coverage permission.

Module description

This module will let you populate a webform select component with data from a view. To use this module:

  1. Create a new view (or edit an existing view).
  2. Create a "Webform Options" display.
  3. Add the fields you want to use as key and value for the select list as you please.
  4. Modify the format options to choose the fields to use as key and value.
  5. Add the select component to your webform and pick your view under "Load a Pre-Built Option List".

Please keep in mind that the list will be included from the view and is not a hard coded list. When the webform is viewed, the component will get its data directly from the view. When viewing the results, only the 'key' may be available when the item is no longer in the view results.

Project information

Project page: https://www.drupal.org/project/webform_views_select
Git clone: git clone --branch 7.x-1.x https://git.drupal.org/project/webform_views_select.git
PAReview: https://pareview.sh/pareview/https-git.drupal.org-project-webform_views_...

My reviews

Comments

Stevel created an issue. See original summary.

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectwebform_views_selectgit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Stevel’s picture

Thanks PA Robot, I was expecting you!

However, the PAReview errors are related to function names inherited from Views, which I can't rename.

Stevel’s picture

Status: Needs work » Needs review

Back to Needs Review

Stevel’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
alex dyakonov’s picture

Status: Needs review » Needs work

Hi @Stevel.
I checked your code with code sniffer and got only few notice.
In the .info files, you have a duplicate key "core".
In the WebformViewsSelectHandler.inc in the 67 row I got a notice:
"As of PHP 5.4 string offsets have to either be integers or integer-like strings. Inspection is extended to all strings since it's a bad practice to use strings as an index of string. http://www.php.net/manual/en/language.types.string.php" - about $rows[''].
Also, you use an array() syntax, but according to Drupal coding standards, you should use a short syntax. (https://www.drupal.org/docs/develop/standards/coding-standards#array).

Stevel’s picture

Status: Needs work » Needs review

Hi Alex,

- The duplicate core key is added by the Drupal.org packaging script and is not present in the git respository
- I added a patch for the notice in #2921207: Notice in WebformViewsSelectHandler line 67. Could you test if that resolves the notice?
- The array() syntax is still required for D7 projects that support PHP 5.2+:

Please note, short array syntax is unsupported in versions of PHP prior to 5.4. This means that Drupal 7 core and Drupal 7 contributed projects without an explicit PHP 5.4+ requirement must use long array syntax.

Stevel’s picture

The patch for the notice has been committed to the git repository. The other remarks are addressed (or so I believe) by my comments above.

Nandu.Kumar’s picture

Status: Needs review » Needs work

Hi,

kindly see the PAReview automated review of your project
https://pareview.sh/node/2664

Stevel’s picture

Status: Needs work » Needs review

Hi @Nandu123,

The remarks given there are methods overridden from Views classes, so I can't choose their names.

Stevel’s picture

Is there anything else I can do to help in the review of this project?

Stevel’s picture

Issue summary: View changes

Updated the PAReview link in the description above, since the old one was no longer working (404 not found).

Nandu.Kumar’s picture

Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

Hey @Stevel,

i am able to see some error in Pareview of your project.
Pareview reports some new warnings:

The headings in the README.txt file should be uppercase.
The module does not implement hook_help().
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

https://pareview.sh/pareview/https-git.drupal.org-project-webform_views_...

Stevel’s picture

Status: Needs work » Needs review

@Nandu123 Thanks for taking the time to review this module.

I fixed the README.txt file to match the standards and implemented a basic hook_help().

The coder sniffer issues are related to Views methods that are overridden, so I can't change these method names.

Are there any other issues that I should look into?

sleitner’s picture

Status: Needs review » Reviewed & tested by the community

Automated Review

Review of the 7.x-1.x branch (commit c13dfb6):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
no issues

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

apaderno’s picture

Issue tags: +PAreview: review bonus

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.