[D8] Select Box

Hi mnsh1416,

Good job, this module worked for me. Please add Configuration link(/admin/config/select_box) on Configuration page (/admin/config).

Thanks

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Pareview.sh showing some errors in README file. Those are not major issues but you can resolve them before module is going LIVE.

https://pareview.sh/node/1854

Thanks,

Hi,
Automated Review Test Result
https://pareview.sh/node/1856

Automated Review
---------------------------------
https://pareview.sh/node/1856

Hi,
I have checked your 7.x and master branch and i got automatic test errors. Please check the attached screenshot.
https://git.drupal.org/project/selectbox.git 7.x-1.x

https://pareview.sh/node/1865

Manual Review
------------------------------
1. File tag is missing in selectbox.module file.

Individual user account

[Yes: Follows]

No duplication

[Yes: No duplicate module]

Master Branch

[No: Does not follow] the guidelines for master branch.

Licensing

[Yes: Follows].

3rd party assets/code

[Yes: Follows]

README.txt/README.md

[No: Does not follow] Missing troubleshooting,FAQ & Maintainers section guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] code is good to review

Secure code

[Yes: Meets the security requirements

Review Points:

1 - Improve/add more content in hook_help() .
2 - Improve your module README.txt

README Template:

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
Thanks

@mnsh1416,

While reviewing the module I found that no config is being set on installation.

What you can do is, you can set it in module_name.settigs.yml that will be placed in config/install/

Hello,

I've reviewed this module and here is a list of my suggestions:

Project type can be changed to "Full project" by yourself. This feature was added recently. Please see how to do that: https://www.drupal.org/node/1068952

package: Custom is a default package if you generate a module by Drupal console, as I remember.
It's better to set package used by similar contrib modules or "Other" as a fallback.

There are two similar files: select_box.links.menu.yml and selectbox.links.menu.yml
Probably, the second one should be removed.

if ($field_definition->getType() == 'list_string' || $field_definition->getType() == 'list_integer' || $field_definition->getType() == 'list_float') {

Three conditions could be replaced with single in_array().

'mobile' => $this->settings->get('sb.mobile') ? TRUE : FALSE,

This statement can be replaced with more readable and shorter:

(bool) 'mobile' => $this->settings->get('sb.mobile'),

$config = $this->configFactory->getEditable('select_box.settings');

There is a method config($name) in ConfigFormBaseTrait that returns editable config object.
Please see for details: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...

All these issues are no so critical, so let's keep "Needs review". Anyway, it will be great to fix them.

Thanks!

I'd like to add the results of a semi-automated test. All minor issues, but together with above comments, I'd suggest a little fine-tuning of the module before anyone else starts reviewing it (there are enough modules in the queue that need review) and set it back to "Needs work".

Review of the 8.x-1.x branch (commit 59d1b06):

• Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• The select_box.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

There are few things to be fixed (https://pareview.sh/pareview/https-git.drupal.org-sandbox-mnsh1416-28771...), but those should not be application-blockers. I didn't find any security issue.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.