Select Box
================
1. This module will change the look and feel of default select lists( text, integer, float) irrespective of theme/user role in order to provide same styling globally.
2. This module provides settings form so that, Admin can change the effects, speed and looping of a lists.
Requirements
================
* Drupal Libraries module (http://drupal.org/project/libraries)
* jQuery selectBox (https://github.com/marcj/jquery-selectBox)
Drush
------
A Drush command is provides for easy installation of the Select Box plugin itself.
% drush select-box-plugin
The command will download the plugin and unpack it in "libraries/".
It is possible to add another path as an option to the command, but not
recommended unless you know what you are doing.
Installation
================
1) Create a libraries/ directory on your server
2) Create a directory within libraries/ named "select-box"
3) Download the latest jQuery selectBox plugin from https://github.com/marcj/jquery-selectBox
4) Enable the jQuery Select Box module
Configuration:
============================
Configure your settings for SelectBox at /admin/config/user-interface/select-box
with an admin configuration settings, you can change the effect of select list through out the site.
Project Url:
============================
https://www.drupal.org/sandbox/mnsh1416/2877193
Project Git Url:
============================
git clone --branch 8.x-1.x https://git.drupal.org/sandbox/mnsh1416/2877193.git select_box
cd select_box
Manual Reviews:
============================
https://www.drupal.org/node/2877881#comment-12083008
https://www.drupal.org/node/2877881#comment-12088632
https://www.drupal.org/node/2878241#comment-12088638
https://www.drupal.org/node/2878954#comment-12089756
https://www.drupal.org/node/2875849#comment-12088898
https://www.drupal.org/node/2872691#comment-12089782
Comment | File | Size | Author |
---|---|---|---|
Configure Select Box.png | 49.51 KB | mnsh1416 |
Comments
Comment #2
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #3
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #4
B N Pandey CreditAttribution: B N Pandey at TO THE NEW commentedHi mnsh1416,
Good job, this module worked for me. Please add Configuration link(/admin/config/select_box) on Configuration page (/admin/config).
Thanks
Comment #5
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #6
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedThanks @B.N Pandey
I have added configuration link under the "user interface" section.
Comment #7
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #8
PA robot CreditAttribution: PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #9
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #10
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #11
hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commentedPareview.sh showing some errors in README file. Those are not major issues but you can resolve them before module is going LIVE.
https://pareview.sh/node/1854
Thanks,
Comment #12
shylajaphp CreditAttribution: shylajaphp at Iksula commentedHi,
Automated Review Test Result
https://pareview.sh/node/1856
Comment #13
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedHi @shylajaphp,
You have shared the "Review Test Result" of some other Repo.
Please check with https://git.drupal.org/sandbox/mnsh1416/2877193
Comment #14
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedThanks @hiramanpatil.
Comment #15
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #16
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #17
shylajaphp CreditAttribution: shylajaphp at Iksula commentedAutomated Review
---------------------------------
https://pareview.sh/node/1856
Comment #18
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commented@shylajaphp,
As I mentioned earlier for you, Please check with https://git.drupal.org/sandbox/mnsh1416/2877193
https://pareview.sh/node/1854
This is test result I got from "pareview.sh"
Comment #19
shylajaphp CreditAttribution: shylajaphp at Iksula commentedHi,
I have checked your 7.x and master branch and i got automatic test errors. Please check the attached screenshot.
https://git.drupal.org/project/selectbox.git 7.x-1.x
https://pareview.sh/node/1865
Comment #20
shylajaphp CreditAttribution: shylajaphp at Iksula commentedManual Review
------------------------------
1. File tag is missing in selectbox.module file.
Comment #21
amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedReview Points:
1 - Improve/add more content in hook_help() .
2 - Improve your module README.txt
README Template:
https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
Thanks
Comment #22
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedComment #23
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedThanks @amit.drupal and shylajaphp,
I have implemented your suggestions along with Drush integration to download required library via drush cmd:
drush select-box-plugin
Comment #24
soaratul CreditAttribution: soaratul at TO THE NEW commented@mnsh1416,
While reviewing the module I found that no config is being set on installation.
What you can do is, you can set it in module_name.settigs.yml that will be placed in config/install/
Comment #25
mnsh1416 CreditAttribution: mnsh1416 as a volunteer and at TO THE NEW commentedHi @soaratul,
I have implemented your suggestion.
Comment #26
MatroskeenHello,
I've reviewed this module and here is a list of my suggestions:
Project type can be changed to "Full project" by yourself. This feature was added recently. Please see how to do that: https://www.drupal.org/node/1068952
package: Custom
is a default package if you generate a module by Drupal console, as I remember.It's better to set package used by similar contrib modules or "Other" as a fallback.
There are two similar files:
select_box.links.menu.yml
andselectbox.links.menu.yml
Probably, the second one should be removed.
if ($field_definition->getType() == 'list_string' || $field_definition->getType() == 'list_integer' || $field_definition->getType() == 'list_float') {
Three conditions could be replaced with single
in_array()
.'mobile' => $this->settings->get('sb.mobile') ? TRUE : FALSE,
This statement can be replaced with more readable and shorter:
(bool) 'mobile' => $this->settings->get('sb.mobile'),
$config = $this->configFactory->getEditable('select_box.settings');
There is a method
config($name)
inConfigFormBaseTrait
that returns editable config object.Please see for details: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...
All these issues are no so critical, so let's keep "Needs review". Anyway, it will be great to fix them.
Thanks!
Comment #27
Mario SteinitzI'd like to add the results of a semi-automated test. All minor issues, but together with above comments, I'd suggest a little fine-tuning of the module before anyone else starts reviewing it (there are enough modules in the queue that need review) and set it back to "Needs work".
Review of the 8.x-1.x branch (commit 59d1b06):
hook_help()
. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Comment #28
apadernoThere are few things to be fixed (https://pareview.sh/pareview/https-git.drupal.org-sandbox-mnsh1416-28771...), but those should not be application-blockers. I didn't find any security issue.
Comment #29
apadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.