[D7] Views Load All Pager

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxsamit3102839645git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Samit,

Nice module. Really like the concept. This module will be of great use.

Hope to use it in my projects soon.

Looks like RTBC +1

Thanks

Hi Samit.310,

Nice module. My manual review.

1. I think you should use t in summary_title function in views_plugin_pager_load_all.inc.

    return format_plural(
            $initial_page_items, 'Initial page @initial_page_items items, ', 'Initial page @initial_page_items items, ', array('@initial_page_items' => $initial_page_items))
        . format_plural(
            $this->options['items_per_page'], 'Second page @count items', 'Second page @count items', array(
          '@count' => $this->options['items_per_page'],
            )
        ) . $offset;

2. Line 105 in views_plugin_pager_load_all.inc you switched quotation styles.

Minor issues. Everything else looks good.

@monstrfolk: looks like you forgot to change the status. Is this now RTBC after your review?

Sorry. New to the review process. I am assuming after two reviews the second reviewer sets to RTBC if everything looks good.

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

I am closing due to lack of replies.

If you are still working on this application, and you need to be able to opt in the security coverage for the projects you maintain, please set the status to Needs review. (See also the project application workflow).

I am changing the status to Reviewed & tested by the community, since that is the status set on #9.

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.