[D7] Forum admin

I fixed the git clone URL.

See the output of the automated test.
http://pareview.sh/pareview/httpsgitdrupalorgsandboxgolds2763921git-7x-1x

You need to set the master branch. See this link https://www.drupal.org/node/1659588

in file fourm_admin.module line 139 and 140. you still have debug function calls. These should be removed.

      dpm($subject);
      dpm($body);

As mentioned in the test using LANGUAGE_NONE is better than using ['und]

I have reviewed your code and found some issues.

Automated Review

Please use pareview and make sure no issues are reported:

http://pareview.sh/pareview/httpsgitdrupalorgsandboxgolds2763921git

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them.  However, modules should follow them as closely as possible.

Manual Review

 

Individual user account

 

Yes: Follows the guidelines for individual user accounts.

 

No duplication

 

Yes: Does not cause module duplication and/or fragmentation.

 

Master Branch

 

No: Does not follow the guidelines for master branch.

 

Licensing

 

Yes: Follows the licensing requirements.

 

3rd party assets/code

 

Yes: Follows the guidelines for 3rd party assets/code.

 

README.txt/README.md

 

No: Does not follow the guidelines for in-project documentation and/or the README Template.

 

Code long/complex enough for review

 

Yes: Follows the guidelines for project length and complexity.

 

Secure code

 

Yes: Meets the security requirements.

 

Coding style & Drupal API usage

 

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
   

     
1. (*) Major finding, needs work

     

2. (+) Release blocker

     

3. Just a recommendation

     

4. ...]

     

5. Beter category for the module (Forum?)
     
6. (*)Sereral issues with coding standards (please check the Drupal coding standards):

   • Comments should be correct sentences: start with a capital and end with a dot.

   


   • Missing doxygen for some functions.

   


   • Missing , at the end of an array.
   • Remove debug code (dpm)
7. (*)I would change the field name to forum_admin_email to make it more specific and better avoidance of conflicts in the name.




8. A cache_clear_all() should not be needed in the forum_admin_add_admin_field function.




9. (+)A dependency on Mail Edit (https://www.drupal.org/project/mail_edit) for editing the body and subject of the e-mail is better in my opinion.

If you choose the Mail Edit path the following review comments are irrelevent as I assume you’ll remove this code.

1. (*) Variable names should be prefixed with the module name to prevent conflicts.




2. (+) You specify the ‘use the replacement patterns’ but you do not provide the possible tokens. Check for the token contrib and if available, add a token_tree.

   

   

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

 

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi golds

Manual Review

Delete variables while uninstalling the module using hook_uninstall() .

Use t() in forum_admin_form_forum_form_forum_alter function.

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

Automated Review

Git errors:

• The last commit message is just one word, you should provide a meaningful short summary what you changed. See https://www.drupal.org/node/52287

Review of the 7.x-1.x branch (commit bb25891):

• Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
• The forum_admin.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/forum_admin.install
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 22 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 22 | ERROR | [x] Inline comments must start with a capital letter
 22 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
 23 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 28 | ERROR | [x] Inline comments must start with a capital letter
 28 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 551ms; Memory: 4Mb

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts. All commits are not assigned correctly, correct your git name/email

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) change name = forum_admin to name = Forum Admin in forum_admin.info
2. (*) change description it must be in one line in forum_admin.info
3. (+) change package = Forum Admin to package = Forum in forum_admin.info

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.