[D7] Commerce LiqPay

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

There is some coding standard errors to fix : http://pareview.sh/pareview/httpgitdrupalorgsandboxbohart2680989git

Individual user account
Yes

Duplication
No

Master Branch
Yes. Branch 7.x-1.x

Licensing
Yes. Follow

3rd party assets/code
Yes follow. Do not contains any 3dr party.

Code long/complex enough for review
Yes. Well documented. Extending views sort, fields and argument.

Secure code
None security issue found. Looks good.

Coding style & Drupal API usage
After a manuel Review, everything seems to be ok. Perhaps, just some recommandations :
-README.txt is missing.That should be in you module.
-On line 143 in commerce_liqpay.module file, Only string literals should be passed to t() .

Module works fine, without errors.

Manual Review

1) On line 143 in commerce_liqpay.module file, Only string literals should be passed to t()
2) On line 29 in commerce_liqpay.module file, Only string literals should be passed to t()
3) On line 172 in commerce_liqpay.module file, Only string literals should be passed to t()
4) On line 120 in commerce_liqpay.commerce.inc file, Only string literals should be passed to t()

I've tested this module locally and approve that defined functionality is working properly.

Hey there
I've finished looking through the code of module and found it looks nice.
I see no additional issues that could be the blockers for promoting this sandbox to a full project
Let's do it

Hey @bohat

It seems that this module not handle multiple payment rules - please check as example for you
http://cgit.drupalcode.org/commerce_interkassa/tree/commerce_interkassa.... and http://cgit.drupalcode.org/commerce_interkassa/tree/commerce_interkassa....

All other looks good

Also you should check if server_url really have call on any payment status change. If not, you should handle "fallback" for this status
Please check as example is_interaction parameter http://cgit.drupalcode.org/commerce_interkassa/tree/commerce_interkassa....

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi all,

I did a review: checked Drupal code styles (looks code) and did some basing testing.
Found one warning, for which I have created a patch:
https://www.drupal.org/project/commerce_liqpay/issues/2931219#comment-12...

The remaining things to check:

1. Test the payment process itself.
2. Fix documentation for functions (parameters are not documented well).

Hello,

@max-kuzomko, thanks for the review.

Your patch was committed! The issue is fixed.

Regarding this point,

2. Fix documentation for functions (parameters are not documented well).

It was fixed in this issue: #2932126-3: Document parameters for custom functions

Added references to the manual reviews and added review bonus tag.

Some minor code style and documentation issues left.

Review of the 7.x-1.x branch (commit 64441a6):

• Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• The commerce_liqpay.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ./commerce_liqpay.module
  --------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  --------------------------------------------------------------------------
   163 | ERROR | Type hint "array" missing for $settings
  --------------------------------------------------------------------------
  
  Time: 162ms; Memory: 8Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Minor code style and documentation issues were fixed here: #2947881: PAReview.sh minor issues .

Probably, some automated tests will be added later. I believe they shouldn't block this module to go.

Moved back to "Needs review".

Checked code, no complains. RTBC.

Doc is https://www.drupal.org/node/475848

According it
- needs stable release (rc1 now)
- needs test coverage

Those are the documentation for which versions are checked from the Drupal Security team. Applying to be able to opt in the security coverage doesn't have those requirements, but its own requirements, which say:

Before you enter the project application process, you should first make sure that your project is a release candidate (RC). You don’t have to make the tags and releases right away – your project should measure up to the RC standard. Entering the process too early with a poorly documented and buggy project will usually result in the review process taking a much longer time than necessary.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.