[D7] Documentum Stream Wrapper

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjoelgilchrist2557493git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I have reviewed code and found following issues:

1) $form_state argument should have ampersand symbol(&) in parameter.
File : documentum_stream_wrapper.admin.inc
function documentum_stream_wrapper_configuration_form($form, $form_state) {
function documentum_stream_wrapper_configuration_form_submit($form, $form_state) {

2) Maintain files in specific folders like js file should be in 'js' folder, inc files should be in "includes" folders.

3) I would suggest it will be good if you will use a form tpl for design form instead of use #prefix and #suffix.

I have checked Point #1 and #2 and it's implemented.
But I am not still fully satisfied with solution of #3.
you can make it more better with this reference link THEMING FORMS WITH TEMPLATE FILES

Review of the 7.x-1.x branch (commit 5f4f7ec):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/css/documentum_stream_wrapper.css
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
   3 | ERROR | [x] Whitespace found at end of line
  ----------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/documentum_stream_wrapper.info
  ----------------------------------------------------------------------
  FOUND 2 ERRORS AFFECTING 2 LINES
  ----------------------------------------------------------------------
   13 | ERROR | Declared file was not found
   14 | ERROR | Declared file was not found
  ----------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. documentum_stream_wrapper_file_add_search(): do not use drupal_add_css() here, use #attached on the $form render array. See https://api.drupal.org/api/drupal/developer--topics--forms_api_reference...
2. documentum_stream_wrapper_repository_search(): if you are worried about DQL injection here you should make sure that the integers are numbers and that $term escaped for quote characters.
3. "'#value' => 'Save configuration',": all user facing text must run through t() for translation.
4. documentum_stream_wrapper_configuration_form(): this is vulnerable to XSS exploits. If I enter <script>alert('XSS'); as repository name for example then I will get a nasty javascript popup in the overview table. You need sanitize user provided text before printing in a table, make sure to read https://www.drupal.org/node/28984 again. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

manual review:
documentum_stream_wrapper_file_add_search(): you are building a tableselect here, but you do not sanitize file_name which is coming from an external untrusted source, right? Same for oid.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

I am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.