The name of your module or theme:
Biblio DAI (biblio_dai)
A detailed description of what it does:
This module adds a Digital Author Identifier (DAI) field to the contributor data within the Bibliography module (biblio). The DAI is a unique national number for every author active within a Dutch university, university of applied sciences, or research institute.
A link to its sandbox project on Drupal.org:
https://www.drupal.org/sandbox/gkaas/2495045
Git clone command:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/gkaas/2495045.git
The intended Drupal core version (eg. 6.x or 7.x):
7.x
Module review by Sutharsan:
https://www.drupal.org/node/2513450
Comment | File | Size | Author |
---|---|---|---|
#6 | Biblio_DAI.png | 73.69 KB | SamirMtl |
Comments
Comment #1
gkaas CreditAttribution: gkaas as a volunteer commentedComment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgkaas2495045git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
rrfegade CreditAttribution: rrfegade commentedHi Gerben Kaas,
Please see the below mentioned errors from your module and rectify them.
Automated Review
There are few errors reported by the automated code review tool, Please correct them first, here is the report : http://pareview.sh/pareview/httpgitdrupalorgsandboxgkaas2495045git
Manual Review
expected "BIBLIO_DAI_DAI_MIN_CHARS" but found "DAI_MIN_CHARS"
expected "BIBLIO_DAI_DAI_MAX_CHARS" but found "DAI_MAX_CHARS"
hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* Implements
hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
This review uses the Project Application Review Template.
Comment #4
gkaas CreditAttribution: gkaas as a volunteer commentedHi Ravindra Fegade,
Thanks, I have resolved most issues. I agree that the module is quite short, but I guess there's not much to add at this moment...
Comment #5
gkaas CreditAttribution: gkaas as a volunteer commentedThe module is updated after a review by Sutharsan:
https://www.drupal.org/node/2513450
Comment #6
SamirMtl CreditAttribution: SamirMtl commentedHi gkaas
By enabling biblio_dai module, (fresh instalation, no already content) i have this notice error : (Please see the screenshot)
Notice: Undefined variable: rows in biblio_dai_author_dai_view() (line 115 of /home/samir/projects/drupal-review/target/drupal/sites/all/modules/biblio_dai/biblio_dai.module).
May be, it is better to check if there are contributor into the result (biblio_dai.module line 103) before you seed the table rows and you can add
'empty' =>t('Your table is empty') in : $output .= theme('table', array('header' => $header, 'rows' => $rows,'empty' =>t('Your table is empty'),)); (biblio_dai.module line 115)
Comment #7
SamirMtl CreditAttribution: SamirMtl commentedComment #8
gkaas CreditAttribution: gkaas as a volunteer commentedThanks for your review Samir! I'll fix this...
Comment #9
gkaas CreditAttribution: gkaas as a volunteer commentedFixed the issue as reported by Samir in comment #6...
Comment #10
hesnvabr CreditAttribution: hesnvabr commented/var/www/html/d7/2495045 (7.x-1.x=) $ cat biblio_dai.module
// Output results as table.
$output .= theme('table', array(
'header' => $header,
'rows' => $rows,
'empty' => t('The author table is empty.'),
));
return $output;
}
Expected 4 spaces but i found 8 in array .
-> header
-> rows
-> empty
-> ))
Comment #11
gkaas CreditAttribution: gkaas as a volunteer commentedThanks Pranav, I have fixed an issue and hopefully this one too.
Comment #12
Warped CreditAttribution: Warped as a volunteer commentedThank you for your contribution!
After 2017 March 7 everyone can promote a project to a full project. A full project has a short project name and a drupal.org/project URL. It can also have releases (like alpha1 or 1.0). Edit your sandbox project, and then choose the 'Promote' tab.
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...
If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs' review
Immense apologies for how long it took to get to this review completed.
Comment #13
apadernoI am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.