Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a drupal 7 theme with the following features:
3-column simple theme initially developed for automobiles site.
8 Regions for different blocks/content of the site.
Clean css, Html.
Jquery banner configurable on homepage only.
Standard drupal 7 theme with proper commenting and clean code.
Clean on all standard browsers and versions.
Project page: https://drupal.org/sandbox/muhammad.tanweer/1079224
Git: git clone http://git.drupal.org/sandbox/muhammad.tanweer/1079224.git automobile
Webgit: http://drupalcode.org/sandbox/muhammad.tanweer/1079224.git
Comment | File | Size | Author |
---|---|---|---|
#6 | footer_spacing.png | 12.25 KB | zymphonies-dev |
#6 | article.png | 44.74 KB | zymphonies-dev |
#6 | footer.png | 4.73 KB | zymphonies-dev |
#6 | content_wrapper.png | 45.36 KB | zymphonies-dev |
Comments
Comment #1
patrickd CreditAttribution: patrickd commentedWelcome!
There's no code to review, you've only done an initial commit yet.
Please read how to use GIT on drupal.org: https://drupal.org/documentation/git
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
regards
Comment #2
2012AudiA6 CreditAttribution: 2012AudiA6 commentedThanks for the tip
Comment #3
muhammad.tanweer CreditAttribution: muhammad.tanweer commentedHello Patrickd,
Thanks for the useful instructions.
I have now added the code to git repository. Please review the code.
Thanks
Comment #4
jleiva CreditAttribution: jleiva commentedHi muhammad.tanweer, my manual review so far:
function bartik_process
and tpl's too.Comment #5
myshofer CreditAttribution: myshofer commentedhi thanks for these suggestions.really helpfull.
Comment #6
zymphonies-dev CreditAttribution: zymphonies-dev commentedHI,
Manual Review:
Please fix these following UI bugs.
1) Give wrapper 20px bottom padding.
2) align article page element properly (left align).
3) region-footer is going out of the frame.
4) Increase content wrapper width in inner page.
( attached screenshot for 1,2,3,4 points )
thanks
shanidkv
Comment #7
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #7.0
klausiadded project info