New Relic API

Ironically, I was looking for something that did this earlier this week. I would recommend putting some more information about the module (e.g. what integration this module provides). It might be worth having a two sentence overview of what New Relic is, as well as a link to their site.

I've done a quick manual review of the code, and I would recommend a few things:

• The link to your code is not actually correct - it should like to http://git.drupal.org/sandbox/TravisCarden/1410944.git (currently you link to drupalcode.org).
• At the start of each function that implements a hook_ indicate what hook your are implementing. e.g. in newrelicapi.admin.inc indicate that you implement hook_settings_form with the first line of your comment being:
  

   *  Implements hook_settings_form().
  

  You already do this in your module file.

• Make it clear that your module depends on the New Relic php extension - i.e. this module does not replace the New Relic php extension, but builds on it

I've run the automated review against your module, and it's picked up some issues.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

Hi @TravisCarden,

I went through your module. Here's some notes:

.info -file

configure = admin/settings/newrelicapi is D7 only.

.admin.inc -file

You're using the t()-function incorrectly when you use links.
Instead of

'#description' => t(
      'When enabled this will !documentation_link New Relic !feature_link.',
      array(
        '!documentation_link' => l(t('manually instrument'), 'http://newrelic.com/docs/php/real-user-monitoring-in-php', array('fragment' => 'manual')),
        '!feature_link' => l(t('Real User Monitoring'), 'http://newrelic.com/features/real-user-monitoring'),
      )
    ),

use this

'#description' => t(
      'When enabled this will <a href="@documentation_link">manually instrument</a> New Relic <a href="@feature_link">Real User Monitoring</a>.',
      array(
        '@documentation_link' => url('http://newrelic.com/docs/php/real-user-monitoring-in-php', array('fragment' => 'manual')),
        '@feature_link' => url('http://newrelic.com/features/real-user-monitoring'),
      )
    ),

You should test my code above first. Wrote it from memory.
For more info on t()-function usage, see http://api.drupal.org/api/drupal/includes%21common.inc/function/t/6

.module -file

Using hook_init() is not the best choice here, as it is completely passed when caching is enabled.

At first I thought it was ok, since you're merely adding JS, which is ok to do here. But I noticed you're using newrelic_get_browser_timing_header & newrelic_get_browser_timing_footer which should be run on every page load if I've understood correctly.

So, I suggest using hook_boot instead of hook_init to make sure it loads every time, even with cache enabled.
See API: http://api.drupal.org/api/drupal/developer%21hooks%21core.php/function/h...

Other notes

There's already http://drupal.org/project/new_relic_rpm as you've probably noticed. So why should there exist two New Relic modules? What's the difference, should they merge?

I'm very sorry about the delay! :(

Feel free to come back later if you like.

Updated issue summary.