1. Empty patch for Poormanscron: http://qa.drupal.org/pifr/test/26440
    FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: No such module [poormanscron]
    Very simple test suite with no external dependencies. CVS checkout info for the module looks correct, but it shouldn't be failiing on an empty patch.
  2. Empty patch for XML sitemap 7.x-2.x/HEAD: http://qa.drupal.org/pifr/test/23148
    FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: No such module [xmlsitemap_taxonomy].
    There are no tests that should be including or depending on the sub-module xmlsitemap_taxonomy as it's included in the branch, but not ported to D7 yet.
  3. XML sitemap 7.x-2.x/HEAD branch tests: http://qa.drupal.org/pifr/test/23146
    PASSED: [[SimpleTest]]: [MySQL] 411 pass(es).
    We get 100% pass locally and on the bot, but it is important to note that the test bot is missing the "XML sitemap engines functional tests" from xmlsitemap/xmlsitemap_engines/tests/xmlsitemap_engines.test and "XML sitemap robots.txt" from xmlsitemap.test. The former has no external dependencies so should always be run. The latter depends on the robotstxt module which does not have a stable 7.x release, so I'll let that one slide. :)
  4. XML sitemap 6.x-2.x branch tests: http://qa.drupal.org/pifr/test/26130
    FAILED: [[SimpleTest]]: [MySQL] 545 pass(es), 14 fail(s), and 3 exception(es).
    Like the previous item, the engines sub-module tests are being skipped/excluded. The robotstxt integration test are actually being run, but I can tell that the robotstxt isn't getting enabled for that test run since running ?q=robots.txt causes a 404. Also the i18n integration tests are wonky as well and I cannot duplicate the failing results. One of them gets stopped by a fatal error that 'Table 'drupal_checkout.languages' doesn't exist query: SELECT * FROM languages ORDER BY weight ASC, name ASC' from language_list()/language_initialize(). I can't duplicate this either on my local install.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

boombatower’s picture

Assigned: Unassigned » boombatower

Used the following to test #1 locally.

Index: client/pifr_client.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/project_issue_file_review/client/pifr_client.module,v
retrieving revision 1.20
diff -u -r1.20 pifr_client.module
--- client/pifr_client.module	4 Dec 2009 22:21:19 -0000	1.20
+++ client/pifr_client.module	26 Jan 2010 06:30:54 -0000
@@ -26,6 +26,52 @@
  */
 define('PIFR_RECOMMENDED_MEMORY', '256M');
 
+if (!empty($_GET['run'])) {
+  $test = array(
+    'test_id' => '26440',
+    'review' => array(
+      'plugin' => 'pifr_simpletest',
+      'argument' => array(
+        'core' => '6',
+        'tests' => array(),
+        'modules' => array(
+          0 => 'poormanscron',
+        ),
+        'directory' => '',
+        'clone-db' => '',
+        'database' => 'mysql-5.0-isam',
+      ),
+    ),
+    'vcs' => array(
+      'main' => array(
+        'repository' => array(
+          'type' => 'cvs',
+          'url' => ':pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib/contributions/modules/poormanscron',
+        ),
+        'vcs_identifier' => 'DRUPAL-6--2',
+      ),
+      'dependencies' => array(
+        0 => array(
+          'repository' => array(
+            'type' => 'cvs',
+            'url' => ':pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal/drupal',
+          ),
+          'vcs_identifier' => 'DRUPAL-6',
+        ),
+      ),
+    ),
+    'files' => array(
+      0 => 'http://drupal.org/files/issues/pass_1.patch',
+    ),
+  );
+  variable_set('pifr_client_test', $test);
+
+  module_load_include('review.inc', 'pifr_client');
+  pifr_client_review_run();
+
+  exit;
+}
+
 /**
  * Implementation of hook_menu().
  */
Index: client/pifr_client.review.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/project_issue_file_review/client/pifr_client.review.inc,v
retrieving revision 1.14
diff -u -r1.14 pifr_client.review.inc
--- client/pifr_client.review.inc	17 Dec 2009 22:49:00 -0000	1.14
+++ client/pifr_client.review.inc	26 Jan 2010 06:30:54 -0000
@@ -38,13 +38,16 @@
   // Report results
   module_load_include('xmlrpc.inc', 'pifr_client');
   if ($review) {
-    pifr_client_xmlrpc_send_result($review->get_result());
-  }
-
-  if (PIFR_ACTIVE) {
-    // Request next test.
-    pifr_client_cron_request_next();
-  }
+    echo '<pre>';
+    print_r($review->get_result());
+    echo '</pre>';
+//    pifr_client_xmlrpc_send_result($review->get_result());
+  }
+//
+//  if (PIFR_ACTIVE) {
+//    // Request next test.
+//    pifr_client_cron_request_next();
+//  }
 }
 
 /**
boombatower’s picture

Status: Active » Needs review
FileSize
1.94 KB

This should solve patch file issues.

boombatower’s picture

Committed #2.

boombatower’s picture

#3: The second test not running makes sense since projects without stable releases are ignored for the moment. The other test is ignored since the clients do not search the tests directory (patch adds). [committed]

boombatower’s picture

patch #4 should also fix everything from #3-4 except "i18n integration tests" due to missing table.

boombatower’s picture

Status: Needs review » Fixed

#4 seems like an issue with the tests, since I do not have a languages table in my local d6 installs and neither should the bot since it sets up a base d6 site without any non-default modules (minus SimpleTest).

I'll let client maintainers know they need to update.

Dave Reid’s picture

Awesome work boombatower. In #4, the languages table should be installed by locale, which is called in setUp(), so something's going wrong. Matter is I can't duplicate the failures locally. :/

boombatower’s picture

Well yes, but why would it be in the host database? 'langauges' should be something like 's42423059languages'?

I assume you have local installed in host locally?

Dave Reid’s picture

Hmm...that is odd. So it's something probably related to the host environment leaking into the test one, or vice versa. I'll look into it.

Dave Reid’s picture

We discovered there are some very naughty things locale.module is *not* doing on uninstall: #696052: Locale module variables not uninstalled, causes fatal errors.

Dave Reid’s picture

Status: Fixed » Active

Alrighty! Recent changes now have:

  1. Poormanscron 6.x-2.x Branch: http://qa.drupal.org/pifr/test/26438
    Poormanscron 6.x-2.x NULL patch: http://qa.drupal.org/pifr/test/26440
    100% pass. Yay!
  2. Poormanscron HEAD Branch: Not being tested??
  3. XML sitemap HEAD Branch: http://qa.drupal.org/pifr/test/23146
    XML sitemap HEAD NULL patch: http://qa.drupal.org/pifr/test/23252
    100% pass! Yay!
    100% pass and running all the available tests. Yay!
  4. XML sitemap 6.x-2.x Branch: http://qa.drupal.org/pifr/test/26130
    XML sitemap 6.x-2.x NULL patch: http://qa.drupal.org/pifr/test/26490
    FAILED: [[SimpleTest]]: [MySQL] 644 pass(es), 2 fail(s), and 4 exception(es).
    PROBLEM: Still isn't checking out or enabling the robotstxt module even though it has a stable and dev 6.x release. It is also trying to run an i18n module test that is not included in XML sitemap. I don't think it should run tests outside the primary module that is being checked out.
boombatower’s picture

Status: Active » Fixed

poormanscron HEAD won't be tested until you commit.

Yea that's all related to the project_info dependency/module list parsing. Please see #102102: Parse project .info files: present module list and dependency information

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.