Followup from conversation within #1920666: Allow additional external libraries with composer.
This feature would add the ability for testbot to execute a 'composer install' during the installation process for D8 core & contrib modules.
This would likely require a few modifications:
i) formalize the inclusion of drush in testbot (currently, it's really only there as a diagnostic/troubleshooting tool, and could use some updating)
ii) Install/add composer to the testbot build
iii) modifications to the install() method inside review/drupal/pifr_drupal.client.inc
Of course, a next-generation testbot platform which natively supports the running of pre-execute scripts during the build process, where this becomes a test property change instead of an underlying code change, would be preferable. :)
Comment | File | Size | Author |
---|---|---|---|
#2 | add_ability_for_testbot-1923582-2.patch | 861 bytes | timmillwood |
#1 | add-composer-install.patch | 838 bytes | timmillwood |
Comments
Comment #1
timmillwoodHere's a patch that adds the execution of `composer install` in the core directory.
Comment #2
timmillwoodThink this would be a better solution
Comment #3
jthorson CreditAttribution: jthorson commentedJust as a heads up ... I doubt that composer exists on the current PIFR testbot builds, so that would need to be tackled first.
Comment #4
timmillwood@jthorson - It looks like composer is already installed as part of Drush (http://cgit.drupalcode.org/drupaltestbot-puppet/tree/modules/drush/manif...)
This also installs composer_wrapper.sh, I'm happy to take advice and guidance on whether the patch in this issue should be
composer install
orcomposer_wrapper.sh install
.Comment #5
jthorson CreditAttribution: jthorson commentedAh ... fantastic! :)
Comment #6
Crell CreditAttribution: Crell at Palantir.net commentedI would discourage wrapping stuff around composer if we can avoid it. Same for PHPUnit. Let's keep our PHP-world tools as vanilla as possible; if we need something they can't do, PRs welcome! :-)
Comment #7
timmillwoodAwesome @crell, sounds good to me.
Is anyone able to get test this patch with testbot?
Comment #8
Mile23Is there a similar issue under the DrupalCI project? We really should concentrate effort there.
Comment #9
timmillwood@Mile21 - I think there is (but can't find it either) however if this patch can get committed and deployed it will speed things up and we can worry about DrupalCI when it's ready.
Comment #10
Mile23Regarding #3: #2509112: Install Composer to PIFR machines
Comment #11
Mile23Also +1 on #2 patch.
Comment #12
Mile23Hmm. Guess I should have done this first.
Comment #13
timmillwoodClosing as this patch is for the old testbot.