Currently, we're having a number of problems on test setup, primarily with 'failure to create dependency directory' and 'failed to clear checkout directory' issues.

The first is invariably due to "Unable to create .git/index.lock: File exists" issues, and the second is typically associated with a "rm -rf failed: Permission denied" response.

Because these are testbot setup issues, and not related to the file under test, I think the directory clearing should occur before the 'next' test request is made ... this will allow us to validate that the directory is indeed clear, take remedial action if not, and not pick up a test if the bot is in a bad state.

The '.git/index.lock: File exists' issue is particularly interesting ... I've seen this occur on a bot 2 seconds after a successful 'rm -rf sites/default/files/checkout'. This seems to indicate that we may actually have two git processes running in parallel on that bot.

CommentFileSizeAuthor
#2 1903118.patch2.6 KBjthorson

Comments

jthorson’s picture

The setup step should also verify that there are no active git processes currently running ... I suspect that a test cancellation in the middle of a git checkout doesn't actually stop git from creating additional files.

jthorson’s picture

StatusFileSize
new2.6 KB

Something like this ... I know that this approach ends up with two 'clear directory' attempts per test run ... but given the number of current issues this has been causing, I don't really see that as a bad thing!

jthorson’s picture

Status: Active » Fixed

Committed to 6.x-2.x (89828de).

jthorson’s picture

Status: Fixed » Needs review

Reverted in 6.x-2.x (e440b6a).