Closed (duplicate)
Project:
Project Issue File Review
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Jul 2012 at 06:06 UTC
Updated:
10 Dec 2013 at 20:01 UTC
Jump to comment: Most recent
Comments
Comment #1
jthorson commentedFollowup from #1565094: Remove "vendor" directory from PHP syntax check to avoid PHP 5.4 errors.
Comment #2
boombatower commentedAny chance we can install php 5.4 on workers which should solve this right?
Comment #3
jthorson commentedThat would cause the PHP syntax check to use PHP 5.4 syntax rules on all code (D6 and D7 included), thus affecting the linting ... background is in #1565094: Remove "vendor" directory from PHP syntax check to avoid PHP 5.4 errors.
This is just a followup on that issue to track that even some D7 modules could explicitly specify a PHP 5.4 requirement; but the current testbot doesn't have any way of detecting this requirement; and/or changing the syntax checking operation based on whether a project expects PHP 5.3 or 5.4 syntax.
Comment #4
jthorson commentedI think the first step would be to get two different versions of PHP-CLI running concurrently on the same server.
I attempted to compile 5.4.6 from source on an Ubuntu box (in a custom directory), and get it running in parallel with the default 5.3.5 install:
Once we have two versions of PHP-CLI running, we can add logic to chose which php executable is used when executing the run-tests.sh script; and thus start considering the use of 5.4 for D8 tests, and still using 5.3 for D7 tests. (Probably need to tweak the configure arguments; the above was just a proof of concept.)
Comment #5
Crell commentedI think this is now implicit in #1867192: Testbots need to run on 5.4, 5.5, 5.6 and 7.