Issue + organic group incompatibility

After activating og and attempting to add an issue, I'm seeing:

Call to undefined function project_project_nodeapi() in /var/www/html/sites/bonzoproject/sites/all/modules/project/project.module on line 594

The undefined function is in project.inc. Not sure why it's not getting loaded.

I'd get rid of the critical designation on this, but it does seem to make a site with project and og on it unusable right now.

The problem is that og_init() does some loading of nodes before project_init() gets a chance to run and include project.inc. The project module's weight is set to 2 so it goes after og. There must be a good reason for this, so I don't think fiddling with weights is the answer.

I'm not sure og should really be loading up nodes in hook_init(), though there are no restrictions or warnings against doing so.

I guess that means project.inc needs to [somehow] get included earlier in the process, or project_project_nodeapi() should be moved into project.module.

project's current handling of .inc files is completely brain-dead. See #390856: Do a proper page/code split of project.

I committed an initial fix for this: http://drupal.org/cvs?commit=192590 Can y'all try again with OG + issues and see if that solved it? Thanks.

Alas. Oh well, I'm not surprised OG + project + project_issue are having troubles in D6. I haven't tested that combination at all yet. However, I don't really have time to work on a fully reconciliation in the short term, so I'm unassigning myself again in case anyone else wants to pick up the torch and run with it in the meantime.

The problem is still in og_init(), currently in:

  // Set group context and language if needed.
  if ($group_node = og_determine_context()) {
    og_set_theme($group_node);
    og_set_group_context($group_node);
    // TODOL: is this too late for menu links and such?
    og_set_language($group_node);
  }

Basically, it causes project_project_load() to be skipped, therefore the system doesn't have $node->project information and everything is screwed. I am still investigating it, if anybody has a clue, let me know.

Seems to be fixed if I change the weight of project module above og:

mysql> update system set weight=-10 where name = 'project';

changing project module weight fixes undefined function error, still seeing preg_match error

Subscribing ...

I have the same problem too. When I view an issue, I got the error

preg_match() expects parameter 2 to be string, array given in /www/includes/bootstrap.inc on line 771.

And when I tried to edit it, I cannot and got "Invalid project selected." message.

Tagging for #439958: Document issues left before 6.x official release

subscribing

subscribing

I think I've got a fix for this (for me, at least). The problem seems to be that the project_issue_load() hook isn't being called when og is present. I think this is due to the way that includes are handled in project_issues.

I've fixed it by moving the function project_issue_load() from issue.inc to project_issue.module.

I'll try to submit a patch soon.

I'm seeing similar problems when the menu_breadcrumb module is enabled - #454682: Issues with project and menu_breadcrumb integration.

For the record, I did exactly the as jrbeaton in #15 to fix the same issue in project.module. I moved project_project_load() from project.inc to project.module, and now $node->project is populated properly even when og is enabled.

Here's the patch from #15 above.

I confirm this error on a fresh install and this patch resolves the error and og and project associations are properly stored.

The title of this issue has "integration" but the content seems to really about fixing a conflict between the two modules. Should more complete integration between project and og (like not having to specify both associations for each issue) happen in #457622: Port to Drupal 6?

@dww: In that issue you referred us back this one, but this task seems large and specific enough to happen in its own project. Thoughts?

Worked on this today while I was on a plane to NYC. Just got my laptop back online and committed a few fixes:

http://drupal.org/cvs?commit=225324
http://drupal.org/cvs?commit=225326

In my testing, that actually makes it work with you enable OG and project* on a test site, and turn project nodes into groups. I needed to move hook_access() in addition to hook_load().

There's still a lot more work to do over at #405478: Do a proper page/code split of project_issue and #390856: Do a proper page/code split of project (I've got a bunch of patches to commit for #405478 that I also did on the plane, but I'll probably post a message for feedback on the proposed split before I commit them), but at least it's basically working now.

@ezra: Yes, #457622: Port to Drupal 6 is exactly the right place to put code so that:
- if you make each project an OG, then issues that are assigned to a given project automatically use that group as their audience
- the "Create issue" link in the group block includes the project name in the URL
- etc...
Let's meet over there.

Therefore, I'm marking this fixed. If there are still problems, let me know and we can decide where to best address them.

Sorry for the delays on this... OG + project* is one of my big visions for the future. ;)

I am willing to commit changes to OG where we are getting in the way of the big vision.

@moshe: Thanks. I might take you up on that. ;) So far, so good.