Allow modules to apply the formatter to unpublished issues [#3300635]

Problem/Motivation

Currently, project_issue_link_filter_callback checks that the "issue" is published, but that's making an assumption that might not always be desired.

Admin or priviledged users might have permissions to see unpublished nodes and still want the filter to be applied.

We might want to add special markup in the template for these cases too, but right now we don't have the opportunity for it.

Steps to reproduce

As superadmin or user with permissions to see unpublished nodes, type [#1234] where 1234 is an unpublished issue. The text will not be replaced by a link, even if the user has permissions to see it.

Proposed resolution

Allow modules to alter the behaviour if needed.

Comment	File	Size	Author
#5	Screenshot 2022-07-29 at 12.14.45.png	16.91 KB	fjgarlin
#5	Screenshot 2022-07-29 at 12.13.02.png	13.1 KB	fjgarlin

Issue fork project_issue-3300635

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3300635-allow-modules-to changes, plain diff MR !2
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 July 2022 at 09:13

fjgarlin created an issue. See original summary.

Comment #2

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented 29 July 2022 at 09:17

Referenced two issues affected by this behaviour.

Comment #3

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented 29 July 2022 at 10:01

Issue summary:

View changes

Comment #4

29 July 2022 at 10:21

fjgarlin opened merge request !2

Comment #5

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented 29 July 2022 at 10:22

Assigned:	fjgarlin	» Unassigned
Status:	Active	» Needs review

File	Size
Screenshot 2022-07-29 at 12.13.02.png	13.1 KB
Screenshot 2022-07-29 at 12.14.45.png	16.91 KB

I used the code in the MR: https://git.drupalcode.org/project/project_issue/-/merge_requests/2

Then, in another module, implemented the hook like this:

/**
 * Implements hook_project_issue_allow_link_render_alter().
 */
function my_module_project_issue_allow_link_render_alter(&$data) {
   $data['allow_link_render'] = TRUE;
}

I logged in as user uid = 1 and unpublished the comment.

Before:
After:

Note that if no other module alters the data, the behaviour is exactly the same as we have now.

Comment #6

drumm

he/him

NY, US

CreditAttribution: drumm at Drupal Association commented 29 July 2022 at 21:48

We should do this with a separate filter in drupalorg module that we configure to run after the project_issue filter. project_issue leaves [#123] untouched when an issue isn’t matched, so it would be left for us to process. Then we can cleanly disable project_issue module, and keep the [#123] links in documentation and other non-issue content.