Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We knew this intuitively, but didn't know why. I'm quite sure that dev releases never get rebuilt because it just does a "git checkout 7.x-1.x". But there's already a local 7.x-1.x. So it doesn't get pulled. Better a fetch followed by "git checkout origin/7.x-1.x" or something.
Comments
Comment #1
rfayAh but I see we already have this code which was meant to do this:
The problem is that that code will never work if we're *on* that branch.
Comment #2
rfayI think this would probably do it. D6 patch.
Comment #3
rfayI tested this version on qa6-drupal.redesign.devdrupal.org and think it will probably work out.
Comment #4
rfayI think we should do this one. SHould be the same thing.
Comment #5
rcross CreditAttribution: rcross commented@Randy - can you confirm you intended for #3 and #4 to be the same patch? diff shows no difference.
Comment #6
rcross CreditAttribution: rcross commentedI've rerolled this to eliminate the conditional fetching.
Comment #7
rcross CreditAttribution: rcross commentedwrong format. try this one.
Comment #8
rfayLooks OK to me, and let's run through the testing together.
My only question: Why leave the fetch in the else instead of making it unconditional? I know it makes logical sense, but should we just do it even after a clone, for simplicity of code?
Comment #9
rfayCommitted to
6.x-1.x: http://drupalcode.org/project/project_dependency.git/commitdiff/9c045f7
7.x-1.x: http://drupalcode.org/project/project_dependency.git/commitdiff/cc3cc44
Thanks and congrats @rcross
Comment #10
rfayNow this needs to be deployed; looks to me like jenkins/bender isn't really up to the task right now. But hope to get it this week.
Comment #11
rfayneeds drupal.org deployment
Comment #12
rfayIn all the mess of getting the testbots stabilized after infra changes I forgot all about this. Still needs deployment. I'm going to mark it rtbc...
Comment #13
rfayDeployed! Now what will happen?
Comment #15
drumm