Problem/Motivation

"Learn more" opens seemingly random links in the project browser for recipes.

Steps to reproduce

1. Installed latest Drupal CMS.
2. Upgraded project browser to latest dev (after I have seen this issue on beta3 as well). - Upgrading drupal/project_browser (2.1.0-beta3 => dev-2.1.x c4151b5)
3. Enabled Recipes in admin/config/development/project_browser
4. Opened admin/modules/browse/recipes
5. Opened some recipes in the list and clicked on "Learn more" (see recording).

Proposed resolution

CommentFileSizeAuthor
Screencast_20251010_115551.mp44.07 MBmxr576

Issue fork project_browser-3551428

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mxr576 created an issue. See original summary.

aryan singh’s picture

aryan singh commented
Assigned: Unassigned » aryan singh

Working on it!!

aryan singh opened merge request !873

aryan singh’s picture

aryan singh commented
Assigned: aryan singh » Unassigned
Status: Active » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work
aryan singh’s picture

aryan singh commented
Assigned: Unassigned » aryan singh

Doing changes.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +Needs tests

Since we found this quite-legit bug, we'll want to add a test for this condition in the Kernel test in RecipesSourceTest.php

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +backport
aryan singh’s picture

aryan singh commented
Assigned: aryan singh » Unassigned

Did the change required.
As I am new to drupal.org contributions I am not moving further with the test needed for this condition.Will explore more related to this.Meanwhile, if anyone else has a test related to this condition, I would welcome their contribution.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

Adam (phenaproxima) is working on writing a test. Thanks for the report and your contribution, Aryan!

  • chrisfromredfin committed cdd13906 on 2.1.x 
    [#3551428] fix: "Learn more" link points to incorrect project pages

By...

  • chrisfromredfin committed 2eee130e on 2.0.x 
    [#3551428] fix: "Learn more" link points to incorrect project pages

By...
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs work » Fixed

Fixed and backported. Adam is going to file a follow-up to add a regression test, but we wanted to get this into stable!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
Status: Fixed » Needs work

I figure I'll write the tests on another MR in this issue's fork.

chrisfromredfin opened merge request !875

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs work » Needs review

There's a test here in !875, needs review (but I wrote it, so would love someone else's eyes)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » chrisfromredfin
Status: Needs review » Needs work

Couple of minor things.

  • chrisfromredfin committed de6e6cfb on 2.1.x 
    [#3551428] fix: "Learn more" link points to incorrect project pages (...

  • chrisfromredfin committed 5884978f on 2.0.x 
    [#3551428] fix: "Learn more" link points to incorrect project pages (...
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs work » Fixed

Fixed in 2.1.x by writing a test (and refactoring for some helpers), then backported clean to 2.0.x.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.