Problem/Motivation

Breaking changes in 11.2:
#3410938: Create enums for RequirementSeverity and deprecate drupal_requirements_severity() constants
#3497431: Deprecate TestDiscovery test file scanning, use PHPUnit API instead

Steps to reproduce

Try to run PB 2.1.x with Drupal Core 11.2

Proposed resolution

  1. Update the REQUIREMENT_* constants
  2. Switch annotations to attributes for PHPUnit (but don't remove @group yet since the core issue was reverted)

Issue fork project_browser-3527063

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett opened merge request !808

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Update for changes to System requirements » Update for changes required by D11.2

mondrake made their first commit to this issue’s fork.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Cannot find a way out.

1) Cannot bump PHPUnit to 11 as core jobs do. PHPUnit 11 requires sebastian/diff 6, but apparently drupal/core-recommended has requirements that block both updates.

2) Trying to run tests by specifying --directory instead of --module does not work. Strange because tests for Image effects do work: https://git.drupalcode.org/project/image_effects/-/pipelines/508827

Going to bed now...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

@mondrake should be credited wherever we end up fixing our Gitlab setup, when that happens (or in #3526778: Tests not running or failing when using run-tests.sh in 11.2.0-dev)

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3497431: Deprecate TestDiscovery test file scanning, use PHPUnit API instead

Question: in this type of build, what is the path to the directories where test classes are defined? In relation if possible to Drupal's core /core subdirectory.

Asking because if it's missing from the list here (example for Javascript tests section of core's phpunit.xml.dist), we may want to try to add to the MR in #3497431: Deprecate TestDiscovery test file scanning, use PHPUnit API instead.

    <testsuite name="functional-javascript">
      <directory>tests/Drupal/FunctionalJavascriptTests</directory>
      <directory>modules/**/tests/src/FunctionalJavascript</directory>
      <directory>recipes/*/tests/src/FunctionalJavascript</directory>
      <directory>profiles/**/tests/src/FunctionalJavascript</directory>
      <directory>themes/**/tests/src/FunctionalJavascript</directory>
      <directory>../modules/**/tests/src/FunctionalJavascript</directory>
      <directory>../profiles/**/tests/src/FunctionalJavascript</directory>
      <directory>../themes/**/tests/src/FunctionalJavascript</directory>
    </testsuite>
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

That seems extremely shippable, and definitely blocks a 2.1.0 release since that's the one with Drupal 11.2 compatibility.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Wünderbar! This is great.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.