Problem/Motivation

There are some styling in Gin theme related to project browser.We want to move that into the project browser's scope so that we have full control of things, thus eliminating dependencies.

Steps to reproduce

web/themes/contrib/gin/dist/css/components/project_browser.css

is the file present in Gin which is responsible for some of the styling when gin is enabled.

Proposed resolution

Move the

web/themes/contrib/gin/dist/css/components/project_browser.css

file in PB directory.

CommentFileSizeAuthor
#18 3505700-18.png7.95 KBphenaproxima

Issue fork project_browser-3505700

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

utkarsh_33 created an issue. See original summary.

utkarsh_33 opened merge request !721

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review

Once we verify that the changes are we can ask the Gin theme maintainers to remove the styles from gin theme.I'll mark it NR and will request @chrisfromredfin or @phenaproxima to take further decisions.

utkarsh_33’s picture

utkarsh_33 commented

Also adding Status icon and maintenance icon are of different size in Gin theme. for reference as this was brought up from the comment.
I think this will also make things more simpler for The Svelte code should not have custom logic for the Gin theme if i am not wrong.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

Doesn't seem problematic to me, although I do have one question. Also, certain lint checks are failing, so kicking this back for that.

I think we might want to wait until Gin removes their styling and tags a new release (I can ask @saschaeggi to do this), and then we can conflict with any version of Gin older than that one.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review

Loading the CSS related to Gin conditionally as requested.Also the CI is Green so marking it NR again.

utkarsh_33’s picture

utkarsh_33 commented

Merged the latest changes.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

I think that looks pretty good, just a few small changes.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review

Addressed the feedbacks.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Move the Project browser specific styling from gin theme to project browser's scope. » Move the Project Browser-specific styling from Gin
saschaeggi’s picture

saschaeggi
he/him
commented
Related issues: +#3508067: Remove Project Browser-specific styling

Please see https://git.drupalcode.org/project/gin/-/merge_requests/588 in Gin #3508067: Remove Project Browser-specific styling

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Move the Project Browser-specific styling from Gin » [PP-1] Move the Project Browser-specific styling from Gin
Status: Needs review » Postponed

Postponing on #3508067: Remove Project Browser-specific styling.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: [PP-1] Move the Project Browser-specific styling from Gin » Move the Project Browser-specific styling from Gin
Status: Postponed » Needs work

Let's get this up to date and conflict with any version of Gin older than 4.0.6.

saschaeggi’s picture

saschaeggi
he/him
commented

Let me know if anything else is needed to get this over the finish line 🤝

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3505700-18.png7.95 KB

This seems to work as intended with Gin 4.0.6, but the new drop-button alignment isn't great:

I would not consider this a blocker, but maybe we can quick-fix this now.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

That'll do pig, that'll do.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.