Problem/Motivation

The bottom border should be removed from the pb-layout__header so that the pb grid doesn't have a top border.

Steps to reproduce

View the Project Browser Grid.

Proposed resolution

Change the CSS to remove the border added here:
border-bottom: 1px solid
Check to see if the border is needed in another display.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lokapujya created an issue. See original summary.

niharika.s’s picture

Assigned: Unassigned » niharika.s
niharika.s’s picture

Assigned: niharika.s » Unassigned
niharika.s’s picture

Assigned: Unassigned » niharika.s
niharika.s’s picture

I have resolved the issue by removing border in CSS file review the attached document for further details and the exact changes made. Let me know if you have any feedback or additional adjustments.

niharika.s’s picture

Assigned: niharika.s » Unassigned
Status: Active » Needs review
chrisfromredfin’s picture

Status: Needs review » Needs work

Hi niharika.s and welcome; thanks for contributing!

If you could change your .patch to use an MR and the new workflow, that would be helpful. I'm noticing in the .patch file that you would fail for coding standards, since there's an empty blank line where the border directive used to be. MR workflow would catch that in the automated testing!

Thanks :)

chrisfromredfin’s picture

Status: Needs work » Reviewed & tested by the community

Oops, I take that all back - you did! This looks great, thanks. :)

chrisfromredfin’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.