Problem/Motivation

The change #3376203: Filter's checkbox labels look broken at smaller viewports has introduced a StyleLint error in GitLabCI:

css/pb.css
 678:3  ✖  Expected "margin-block-end" to come before "font-size"  order/properties-order
1 problem (1 error, 0 warnings)

We haven't made it mandatory for code quality tests to pass in GitLabCI yet, so it was allowed into the codebase.

Steps to reproduce

See pipeline on #3376203: Filter's checkbox labels look broken at smaller viewports.

Proposed resolution

Should just require swapping of order of styles.

Issue fork project_browser-3423695

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark opened merge request !438

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

StyleLint and all tests (except for PHPCS, which is the subject of ongoing work) are passing.

Setting to needs review.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

Wonderful! Glad you had eyes on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.