Problem/Motivation

The current sort options (some) are unintuitive. We could user plainer, more accessible language.

Steps to reproduce

Spin up current 1.0.x and pull down the sort options.

Proposed resolution

Change the terminology on the sort to:
- Most popular
- Most relevant
- Newest first

h/t @phenaproxima

Issue fork project_browser-3365678

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +core-mvp
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: -core-mvp +core-post-mvp

bcgreen made their first commit to this issue’s fork.

bcgreen’s picture

bcgreen commented

Chris-- am I assuming correctly that 'Most popular' would map to the existing 'Active installs' option, and 'Newest first' would map to 'Recently created'?

Thanks!
Bryan

sakthi_dev made their first commit to this issue’s fork.

sakthi_dev opened merge request !392

sakthi_dev’s picture

sakthi_dev commented
Status: Active » Needs review
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work

Yes, that's correct @bcgreen!

Tests are failing - we are testing against the language being changed. Please update tests:

1) Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserUiTest::testSortingCriteria
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Active installs'
+'Most Popular'

2) Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserUiTest::testMultiplePlugins
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'9 Results Sorted by Active installs'
+'9 Results Sorted by Most Popular'
sakthi_dev’s picture

sakthi_dev commented
Status: Needs work » Needs review

Please review.

Zarpele made their first commit to this issue’s fork.

marcoliver made their first commit to this issue’s fork.

marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Needs review » Reviewed & tested by the community

Change makes sense and issue fork works.

Marking as RTBC.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Thanks, all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.