Problem/Motivation

The Show projects label can be confusing to a new user who is searching for "Modules," and it is not clear (from the label) that this controls pagination."
Show projects label

Steps to reproduce

N/A

Proposed resolution

Change the label to Modules per page
Modules per page label

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
CommentFileSizeAuthor
#8 change-text-3365404-8.patch817 bytessakthi_dev
ModulesPerPageLabel.png36.71 KBjonycp
ShowProjectsLabel.png37.32 KBjonycp

Issue fork project_browser-3365404

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jonycp created an issue. See original summary.

ebremner made their first commit to this issue’s fork.

ebremner opened merge request !385

ebremner’s picture

ebremner CreditAttribution: ebremner at University of Waterloo commented

This is ready to review, made the change to Modules per page.

ebremner’s picture

ebremner CreditAttribution: ebremner at University of Waterloo commented
Status: Active » Needs review
iStryker’s picture

iStryker CreditAttribution: iStryker at University of Waterloo commented

I am reviewing at DrupalCon Pittsburgh

fjgarlin’s picture

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented
Status: Needs review » Needs work

Not sure why the tests are passing. The text change needs to be applied here too: https://git.drupalcode.org/project/project_browser/-/blob/1.0.x/tests/sr... and https://git.drupalcode.org/project/project_browser/-/blob/1.0.x/tests/sr...

sakthi_dev’s picture

sakthi_dev CreditAttribution: sakthi_dev at Specbee for Drupal India Association commented
FileSize
change-text-3365404-8.patch817 bytes
sakthi_dev’s picture

sakthi_dev CreditAttribution: sakthi_dev at Specbee for Drupal India Association commented
Status: Needs work » Needs review

Updated the test file.

fjgarlin’s picture

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented
Status: Needs review » Reviewed & tested by the community

Code looks good, tests are green and I tested it via drupalpod.
Marking it RTBC.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.