Problem/Motivation

Tests started failing in MR may be due to recent code push.
See https://www.drupal.org/pift-ci-job/2487295 and https://www.drupal.org/pift-ci-job/2487274

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3312537

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendraR created an issue. See original summary.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Priority: Normal » Critical

bnjmnm made their first commit to this issue’s fork.

bnjmnm opened merge request !266

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review

This will fix it for now so Project Browser work isn't stalled, but we should probably get Automatic Updates to tag another release so we can depend on a tagged version instead of the dev branch, which would prevent these kind of errors from appearing unexpectedly. This change would need to happen either way so I think it's fine to merge, though.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

MR seems easy enough and the tests do come up green, which is the area that was affected, so marking this as RTBC.
Thanks!

  • bnjmnm committed 537b06b on 1.0.x 
    Issue #3312537 by bnjmnm, narendraR, fjgarlin: Tests started failing in...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

This happened unexpectedly due to Project Browser depending on a dev release of Automatic Updates, which is subject to change at any time. I asked Automatic Updates in Slack if they could tag a new release so PB can rely on a stable version, and I can follow that up with an issue in their queue if needed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.