Problem/Motivation

There should be equal spacing in between module cards when grid view (default) is selected.

Project browse page spacing issue in grid view

Steps to reproduce

- Install the module.
- Check Browse projects page at /admin/modules/browse

Proposed resolution

- Add equal spacing in between module cards without affecting list view.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
CommentFileSizeAuthor
#8 desktop.png47.97 KBlibbna
#8 mobile.png33.81 KBlibbna
#6 Screenshot from 2022-08-24 21-00-05.png126.88 KBlibbna
project-browse-page.png1.7 MBakshayadhav

Issue fork project_browser-3301498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AkshayAdhav created an issue. See original summary.

AkshayAdhav opened merge request !218

AkshayAdhav closed merge request !218

AkshayAdhav opened merge request !221

akshayadhav’s picture

akshayadhav
he/him
Location Pune, India 🇮🇳
commented
Assigned: akshayadhav » Unassigned
Status: Active » Needs review
libbna’s picture

libbna commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2022-08-24 21-00-05.png126.88 KB

Reviewed the MR and the grid is showing in one column. Adding screenshot.

akshayadhav’s picture

akshayadhav
he/him
Location Pune, India 🇮🇳
commented
Status: Needs work » Needs review
libbna’s picture

libbna commented
StatusFileSize
new mobile.png33.81 KB
new desktop.png47.97 KB

Reviewed the last MR and it LGTM. Changing the status to RTBC. Attached images are the results after adding last MR changes.

libbna’s picture

libbna commented
Status: Needs review » Reviewed & tested by the community
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Waiting to get some feedback from designers on if this is beneficial in some way or if the original space is actually preferred.

ruthleopold’s picture

ruthleopold commented

Equal spacing is preferred to indicate that all cards are equally related to each other, rather than intentionally grouped in threes.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +core-post-mvp
sime’s picture

sime
any/any
Location Melbourne
commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Heaps of work since this.