Problem/Motivation

RandomDataPlugin is really useful to check that the front-end is truly agnostic from the back-end connected (mock, jsonapi...). This plugin generates just random data, and all things should still be rendered, clickable, etc.

The only issue is that its purpose is clearly for testing and it made it into the main module's code, so move it away from there.

Steps to reproduce

Enable the module and run "drush config:set project_browser.admin_settings enabled_source random_data".

Proposed resolution

I suggest making it a submodule (module inside the module) so this can also be tested from the UI, not just the tests. Similar to "devel generate" and the like.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fjgarlin created an issue. See original summary.

fjgarlin’s picture

Title: Move RandomDataPlugin to a test module » Move RandomDataPlugin out from the main module

fjgarlin’s picture

Assigned: fjgarlin » Unassigned
Status: Active » Needs review

Testing instructions;
* The new test that was added already use the new feature we're adding, so green means good :-)
* Navigate to /admin/modules and enable "Project Browser Devel" or `ddev drush -y en project_browser_devel`
* Navigate to the project browser page /admin/modules/browse and see that everything is full of random data
* Check that all categories and filters are rendered without issues and all the elements are clickable without JS errors anywhere.

This tests that the front-end can accommodate multiple plugins.

narendraR made their first commit to this issue’s fork.

chrisfromredfin’s picture

Status: Needs review » Reviewed & tested by the community

The threads in the MR were addressed, so I resolved them.

I worry that the tests' CSS selectors are less than ideal, but that's more likely due to our markup, etc. So I think it stays and gets addressed if the tests start failing for that reason. Fired up in Gitpod and enabled project_browser_devel and confirm it working (even after uninstall restoring previous setting). So, RTBC!

tim.plunkett made their first commit to this issue’s fork.

  • tim.plunkett committed a878797 on 1.0.x authored by fjgarlin
    Issue #3281891 by fjgarlin, narendraR: Move RandomDataPlugin out from...
tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.