Problem/Motivation

According to ultimike in #6 here -- https://www.drupal.org/project/project_browser/issues/3247332#comment-14..., installing this package (i.e. through DrupalPod) does not pull in the dependencies as listed in the info.yml.

Steps to reproduce

composer require this project then try to enable it.

Proposed resolution

update the composer.json of this package to require drupal/package_manager

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

Release notes snippet

Adds requisite dependencies to composer.json.

Issue fork project_browser-3248299

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chrisfromredfin created an issue. See original summary.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant commented

Since the automatic update module declares dependency to package manager module as '- drupal:package_manager' in the .info.yml file and doesn't install package manager via composer, I also didn't include it in the MR for connection with the package manager.

If it is creating problems, we can temporarily add this dependency

'drupal/automatic_updates:2.x-dev@dev'

This will resolve the issue for now, but wouldn't be needed going forward if package manager is added to core.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC for University of New England commented

Hmm, well the real issue is that our Gitpod link doesn't work to easily spin up and work with the project. I wonder if the right answer, then, is to actually update the Gitpod link to also install the update manager. I will see if Ofer has any insights.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
CreditAttribution: shaal as a volunteer and at Phase2 commented

It seems that the commit that was done in https://www.drupal.org/project/project_browser/issues/3245770 broke project_browser.

I would suggest making package_manager a dependency in composer.json, as a regular Drupal module.

Only after automatic_updates made its way into core, project_browser should update the dependency from an external module to core module.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant commented

I checked and noticed that the package manager module is part of the 8.x-2.x-dev release of automatic updates and the project browser has marked minimum stability is beta in composer.json. I think it would be better to revert the MR https://www.drupal.org/project/project_browser/issues/3245770 for now.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC for University of New England commented

I tend to think marking stability dev would be OK at this stage of the game. Everything is new and fresh and probably OK to decrease minimum stability.

gaurav.kapoor opened merge request !7

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant commented
Status: Active » Needs review

Added an MR which changes minimum stability to dev and also makes sure required version of automatic update module is installed if someone installs project browser.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented

I reverted the commit from the other issue for now
#3245770-10: Create a service to composer install via package_manager from Automatic Updates

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC for University of New England commented
Status: Needs review » Postponed

Want to wait till post-MVP to get this in, unless there's a big surge of work on Automatic Updates in PB.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Status: Postponed » Closed (outdated)

The Package Manager integration has landed. It's an optional feature that can be activated if Package Manager is installed, but Package Manager is not a hard requirement of Project Browser so it's not specified as such in the info.yml, so the composer.json change is not needed either.

Package manager is a dependency for some tests, so Package Manager is added as a dev dependency via requiring Automatic Updates. Those tests pass, so the composer config seems solid.