Fix Notice: Array to string conversion

I have noticed that when I do php --version

rajab@vardot-dev:/var/www/html/dev/drupal9c1project_browser/web/modules/contrib$ php --version
PHP 7.4.23 (cli) (built: Aug 26 2021 15:51:55) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.23, Copyright (c), by Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans

But when I go to "/admin/reports/status/" with a Drupal 9.2.6 I get

PHP
Version
7.3.30-1+ubuntu21.04.1+deb.sury.org+1 (more information)
It is recommended to upgrade to PHP version 7.4 or higher for the best ongoing support. See PHP's version support documentation and the Drupal 8 PHP requirements handbook page for more information.

Still an issue with public $body = [];
And strip_tags($this->body['summary'], ['p', 'a', 'b', 'i', 'u', 'em', 'strong'])

If changed the body to array
and strip_tags($this->body['summary'], '<p><a><b><i><u><em><strong>')

But at this link
https://www.php.net/manual/en/function.strip-tags.php
it says

$text = '<p>Test paragraph.</p><!-- Comment --> <a href="#fragment">Other text</a>';
echo strip_tags($text);
echo "\n";

// Allow <p> and <a>
echo strip_tags($text, '<p><a>');

// as of PHP 7.4.0 the line above can be written as:
// echo strip_tags($text, ['p', 'a']);

as of PHP 7.4.0 the line above can be written as:

strip_tags($text, ['p', 'a']);

We have to be careful as some body and summaries may have a wrong HTML formatting or some have

<?php 
 ?> 

and inline links with parameters

Note, strip_tags will remove anything looking like a tag - not just tags - i.e. if you have tags in attributes then they may be removed too,

e.g.

    $test='<div a="abc <b>def</b> hij" b="1">x<b>y</b>z</div>';
    $echo strip_tags($test, "<div><b>");

will result in

   <div a="abc bdef/b hij" b="1">x<b>y</b>z</div>Note, strip_tags will remove anything looking like a tag - not just tags - i.e. if you have tags in attributes then they may be removed too,

e.g.

    <?php
    $test='<div a="abc <b>def</b> hij" b="1">x<b>y</b>z</div>';
    $echo strip_tags($test, "<div><b>");

will result in

   <div a="abc bdef/b hij" b="1">x<b>y</b>z</div>

   

Having a patch for PHP7.4
and another for PHP7.3

I like to keep the new way with array for PHP7.4
Maybe it's faster

Not sure if we should keep using strip_tags
as it's not the smartest tag striping way. in case of mixed wrong HTML or some other save filtered data or links

Better patch for PHP7.4

Not sure if we should keep using strip_tags.
If we could use use Drupal\Component\Utility\Html;
and Html::escape

Agrees on using strip_tags for sure.
Searched on how they do strip_tags in Drupal core.
They are using Html::escape(strip_tags($perm_item['title'])).

As Ron said: this should come readily from the new JSON:API endpoint.
Too much to do in local sites for each project. It should have things ready for the Project Browser. Only to play with the UI and render the data.
No extra local pre-processing for data.

My onion on this if we could have a field. which could be named "project_browser_summary" or "plain_text_summary" in projects. Filtering and editing for that will be in the Drupal.org project edit page. and JSON:API could manage extra filtering.

If a custom Project Browser plugin is doing more pre-processing. It will be for a specially fixed filtering case or ready yml or custom JSON:API endpoint.

Follow up on feedback from #14