I couldn't install the module as 'end' (one of the columns name of progress table) is a reserved word with PostgreSQL..
It looks like it is reserved as well with MySQL though.. I wonder how anyone can install this module ??

CommentFileSizeAuthor
#5 progress-7.x-1.x-fix_sql_compliance-2.patch4.91 KBgielfeldt
#2 progress-7.x-1.x-fix_sql_compliance-1.patch3.62 KBthekevinday

Comments

gielfeldt’s picture

gielfeldt commented

Hi guenoz

I'm aware of this. I began on a version for postgres for 6.x, but haven't got around to finish it yet. It does work on MySQL though in spite of the reserved word.

I'm not sure when I'll get it fixed for postgres, so for now it's not supported :-(. Sorry.

I'll leave this ticket open for the refactoring task, so that you may follow the progress.

thekevinday’s picture

thekevinday commented
Version: 7.x-1.3 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new progress-7.x-1.x-fix_sql_compliance-1.patch3.62 KB

I would call this an SQL compliance bug.

The three reserved words are: start, end, and current.

The solution is to not use reserved words.
Problem solved, attached is a patch.

Please review to make sure I did not miss anything.
I will be attempting to fix background_process and ultimate_cron to make sure they are SQL standards compliant as well.

References:
- http://drupal.org/node/141051

gielfeldt’s picture

gielfeldt commented

Cool. Thanks. The reason I haven't looked at this issue yet is because of my tight db coupling from ultimate cron and background process. I was planning on solving this somehow, by avoiding selects directly to the progress table from these two modules.

thekevinday’s picture

thekevinday commented

The only problem I see with this is the API change required.
So, it will work for those who apply all appropriate patches.
But I imagine you'd only be able to make this official by starting a 2.x branch to avoid API breakage.

gielfeldt’s picture

gielfeldt commented
StatusFileSize
new progress-7.x-1.x-fix_sql_compliance-2.patch4.91 KB

Here's the Progress patch as mention in #1751176: SQL Compliance, such as with postgres

thekevinday’s picture

thekevinday commented
Status: Needs review » Reviewed & tested by the community
gielfeldt’s picture

gielfeldt commented
Status: Reviewed & tested by the community » Fixed

Committed to dev!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.