The .install files adds block information for both the default theme and the admin theme.
When these are the same theme, the install fails as there are duplicate keys.

CommentFileSizeAuthor
#1 profiler_builder-duplicate-block-keys-2269117-1.patch2.05 KBthijsvdanker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thijsvdanker’s picture

thijsvdanker CreditAttribution: thijsvdanker commented
Assigned: thijsvdanker » Unassigned
Status: Active » Needs review
FileSize
profiler_builder-duplicate-block-keys-2269117-1.patch2.05 KB

Patch adds an if statement comparing the default and the admin theme before adding the admin blocks.

btopro’s picture

btopro CreditAttribution: btopro commented

makes sense and looks correct; need an additional reviewer and I'll get it added in (strange usage of the same theme for both btw ;))

thijsvdanker’s picture

thijsvdanker CreditAttribution: thijsvdanker commented

Reviewers are hard to find these days eh? :)

btopro’s picture

btopro CreditAttribution: btopro commented
Assigned: Unassigned » mmilutinovic1313

yeah good snarky ping.

I'll have one of my staff members check into this patch. At a glance this looks like it'll apply cleanly and has no negative implications but just would like verification.

thijsvdanker’s picture

thijsvdanker CreditAttribution: thijsvdanker commented

Snarky: A word that should be googled to find the definition as per direction from Dane Cook ~ source

No intention of being snotty or arrogant here :)

Thanks for helping me getting this in.

btopro’s picture

btopro CreditAttribution: btopro commented

ha, nice quote. I snark all the time... like last comment.

Anyway I'll throw this into travis and see if he gets angry. I doubt he will as this looks correct

mmilutinovic1313’s picture

mmilutinovic1313 CreditAttribution: mmilutinovic1313 commented

Testing as we speak!

mmilutinovic1313’s picture

mmilutinovic1313 CreditAttribution: mmilutinovic1313 commented

Testing passed. Patch looks good!

btopro’s picture

btopro CreditAttribution: btopro commented
Assigned: mmilutinovic1313 » btopro
Status: Needs review » Fixed

thx for verification, should find it's way into dev soon

  • btopro committed 39177c4 on 7.x-1.x 
    #2269117 patch applied, fixed
btopro’s picture

btopro CreditAttribution: btopro commented

http://cgit.drupalcode.org/profiler_builder/commit/?id=39177c4 like now :p

thijsvdanker’s picture

thijsvdanker CreditAttribution: thijsvdanker commented

Thanks guys, snark out!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.