Uninstalling Devel before devel generate results in a routing exception on the production check page

Happy to review patches, seems to be a bug indeed!

Or has this already been fixed in latest versions?

Yep, this is still an issue!

Ok, I tracked down the issue.

Inside "/src/Plugin/ProdCheck/Modules", different dev modules are tracked, which should be disabled for production use. Inside each class, an "init" method will initiate the prod_check entry, for the specific module. Since "devel_generate" doesn't have its own static route, the devel route was instead provided, leading to this error, as devel was uninstalled.

I am fairly unsure about these links in general, since they usually point to some random form of the referenced module. In my opinion, they should instead:

1. Link to the uninstallation page of the module
2. Link to help page of the module (if a help page is provided, otherwise there simply is no link)
3. Or removed entirely

@Anybody, any thoughts on this?

Have a look at the MR, this approach would fix the problem for now.

Note, that I couldn't properly inject the service and my linter goes crazy with all the PHPCS issues inside this module, so it is hard to determine what the problem is.

Please review!

Re #6: Sounds like strange and error-prune URL guessing with unclear benefit?

If yes,

Or removed entirely

is the only correct answer. Remove the link and just output the name.

@Anybody, well, it is not quite guessing. The route is simply hard coded inside the class, see this example:

/**
 * Devel generate check
 *
 * @ProdCheck(
 *   id = "devel_generate",
 *   title = @Translation("Devel generate"),
 *   category = "modules",
 *   provider = "devel_generate"
 * )
 */
class DevelGenerate extends ModulesBase {

  /**
   * {@inheritdoc}
   */
  public function init() {
    $this->module = 'devel_generate';
    $this->routeName = 'devel.admin_settings';
  }

}

If the benefit from this is low, it causes trouble and time to fix, remove what's not worth the time...

@Anybody, it won't cause trouble any more, with the patch applied. Let's commit this! It might not be perfect, but putting more time in this and refactoring the link logic isn't worth it and removing the link feature is also not good, as several classes will have an unused route parameter.

@Grevil: Then please add @todo's in all dirty parts.

Thank you @Grevil! This should be refactored in total. Not worth it now, thanks for the fix and the comments!

Glad I could help.