Displaying messages 1 - 1 of 1 >>

Clicking the link does not seem to break anything nor does it for two messages. Anyway, this needs a fix and a test...

CommentFileSizeAuthor
#2 privatemsg_first_pager_bug.patch3.74 KBberdir

Comments

berdir’s picture

Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)

Strange, that does not seem to happen on my local test site, I need to investigate further..

berdir’s picture

StatusFileSize
new3.74 KB

Found the bug. Nice example why good test coverage is not enough. It doesn't help to view a page when testing the wrong stuff :)

For a single page, <> have not been tested and for all other pages, they were not being tested as html encoded: & gt;& gt; instead of >>. Interesting that you have to do it when asserting but it is not necessary when clicking a link...

The actual bug was that the $start < $last_page check did not check if there is only a single page.

berdir’s picture

Status: Postponed (maintainer needs more info) » Needs review
berdir’s picture

Version: 6.x-1.0 » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Fixed in 6.x branches

berdir’s picture

Status: Patch (to be ported) » Fixed

And also in 7.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.