PostgreSQL Error: catchable fatal error on the messages list page

Hi Berdir,

Thanks for your answer ! I didn't know about bisect. As you say, it seems to be very helpful !

I tryed to look into this problem. I am not an expert, but below is what i found.

When i have Catchable fatal error, i did a "return browser" (sorry for my bad english). And this error appers:

PDOException: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: "" LINE 4: WHERE (base.uid IN ('')) ^: SELECT base.uid AS uid, base.name AS name, base.pass AS pass, base.mail AS mail, base.theme AS theme, base.signature AS signature, base.signature_format AS signature_format, base.created AS created, base.access AS access, base.login AS login, base.status AS status, base.timezone AS timezone, base.language AS language, base.picture AS picture, base.init AS init, base.data AS data FROM {users} base WHERE (base.uid IN (:db_condition_placeholder_0)) ; Array ( [:db_condition_placeholder_0] => ) in DrupalDefaultEntityController->load() (line 196 of /usr/local/drupal/includes/entity.inc).

It seems that there is an empty value passed into a query which make PostgreSQL generate an error.

I looked into the foreach set line 86 in privatemsg.module:

foreach ($users as $uid) {
    // If it is an integer, it is a user id.
    $user_ids = privatemsg_user_load_multiple(array($uid));

I added a condition which verify that $uid is not empty

  foreach ($users as $uid) {
    // If it is an integer, it is a user id.
    if(!empty($uid)){
	$user_ids = privatemsg_user_load_multiple(array($uid));
}

And it worked.

I made a patch (for 7.x-1.x) ... but in my opinion it resolves the issue, but it does not explain why $uid is sometimes empty (during the foreach).

I hope this will help in resolving this issue

Sorry to re-up this issue but at this time i cannot upgrade to the latest version of privatemsg.

Would be great if someone can just take a look at this =)

Thanks

Since this is a minor modification and there is no feedback since almost two months, i set this to RTBC. Update the status, if you think this need more testing

Update title, this is a PG issue

Any update on this ?

Yes, it seems more appropriate than just verifiying if it's not empty.

Reroll patch against the current dev.

Patch should resolve also some problems on Oracle too. See https://drupal.org/node/1840428

Would be nice if some PG users can review this in order to make this module play nice with PG again :)

#8: ensure_that_userid_is_integer-1714176-8.patch queued for re-testing.

5 weeks without any comment.

In my Drupal site, i didn't have any problem

Set this to RTBC.

Any chance to get this commited ? :=)