privatemsg for all entity bundles

Please provide a unified diff, it looks like you have a git checkout, so all you need to do is git diff within the privatemsg directory.

The testbot is not going to like this patch.

[08:07:07] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/default/files/review/allbundles-1660876-1.patch 2>&1] succeeded.
[08:07:07] Command [git apply -v -p1 /var/lib/drupaltestbot/sites/default/files/review/allbundles-1660876-1.patch 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/privatemsg]
  Status [1]
 Output: [error: No changes].
[08:07:07] Applied [allbundles-1660876-1.patch] to:
 > no files

Note that new features are only added to the 7.x-2.x branch.

Looks interesting but there are quite some potential issues, some feedback:

- We should change the variable name and add a proper upgrade path from the old settings.
- Migration needs to include the show_on_comments settings, If enabled, all node types that are enabled should have the corresponding comment bundle enabled as well and then the show on comments setting can be removed as well. Users can then fine-tune those settings they way they want to.
- There is no requirement that bundle names are unique, so it is possible that you have e.g. a node and term bundle that's named the same way, probably needs a combined key of entity_type and bundle.
- There is no standard way of getting the uid of an entity. We might need to find a way to filter out those that we don't know it, not sure how yet. Maybe rely on entity propeties from the entity.module.
- Instead of $entity->title, you need to use the entity_label() function.
- Moving the links out of content['links'] is problematic, why is that necessary?

No, I'm saying that we don't need the comment setting anymore because you can now directly enable for which comment bundles you want to have it displayed. The setting isn't check anymore anyway. However, we want to migrate it by selecting the comment bundles as well for the

+++ b/privatemsg.moduleundefined
@@ -2347,40 +2347,46 @@ function privatemsg_build_modes($obj_type) {
+      'href' => $url . '/' . t('Message regarding @bundle', array('@bundle' =>  entity_label($bundle, $entity))),

The argument for entity_label() is the entity type, not the bundle.

The patch now adds a dependency on entity.module, we didn't have that before and that's probably why the tests explode.

Same for that links thing. Yes, it is nice to have DS integration,but your change would almos require DS, no? Because without it, the links aren't displayed within the links as they were before, right?

#12: allbundles-1660876-12.patch queued for re-testing.