When in the update hooks, we run a node_load() before running print_pdf_update_7203(), print_pdf_node_load() will attempt to load the database column "size", however this has not been created yet.

The following issues refer to this problem as well:

#1617654: Print doc
#2297701: Need to remove breadcrumbs and URL from Print pages

CommentFileSizeAuthor
#2 2446939-print-update7203-2.patch997 bytesJorrit
#1 print-2446939-1.patch628 bytesstefan.r
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Priority: Normal » Major
Status: Active » Needs review
FileSize
print-2446939-1.patch628 bytes

Upgrading priority as it can make a database update break due to a fatal error, preventing other update hooks from running.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented
FileSize
2446939-print-update7203-2.patch997 bytes

I think executing db_field_exists() on every node load is a bit too expensive, it executes a query every time it is called.

The attached patch handles PDOExceptions while executing the query, which makes sure that the code executes properly without the columns.

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
CreditAttribution: froboy at Palantir.net commented
Status: Needs review » Reviewed & tested by the community

I just updated an old site from 7.x-1.3 to 7.x-2.2 and this patch allowed me to proceed successfully. It's pretty straightforward, didn't seem to take too long, and works. LGTM.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented

Did you test patch #1 or patch #2?

  • jcnventura committed 4e2acce on 7.x-2.x authored by Jorrit 
    Issue #2446939 by stefan.r, Jorrit, jcnventura: PDOException: SQLSTATE[...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at Wunder commented

Thanks everyone!

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at Wunder commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.