It is useful to have the same feature for other entity types.
Let's create a submodule for prevnext links for taxonomy terms.

CommentFileSizeAuthor
#9 permissions.png76.07 KBastonvictor
#9 settings.png41.11 KBastonvictor

Issue fork prevnext-3398285

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AstonVictor created an issue. See original summary.

AstonVictor opened merge request !18

astonvictor’s picture

astonvictor commented
Assigned: astonvictor » Unassigned
Status: Active » Needs review

Created a new MR.

Created a new submodule for taxonomy terms. It contains all other features from other issues: new permissions, block plugin, view plugin, schema config, etc.

aronne’s picture

aronne commented
Status: Needs review » Needs work

@AstonVictor I don't think creating a submodule for taxonomy terms is the right choice to make.
I would rather do a work of refactoring and create a new Annotation Plugin called PrevNext which could be derived for any entity type so that we won't break the DRY principle.

astonvictor’s picture

astonvictor commented

I guess we can refactor the module to create a new settings page for enabling prevnext links for any content entity types (nodes, taxonomy terms, comments, media items, etc).

After enabling the entity type we can render a list of bundles and other configs (enable permissions and so on) via form states.
It requires updating other plugins/hooks/etc and implementing permission callback to create permissions for enabled entity types.

I think we will need to create a new version of the module for the updates e.g. 3.0.x

astonvictor’s picture

astonvictor commented
Assigned: Unassigned » astonvictor

AstonVictor closed merge request !18

AstonVictor opened merge request !22

astonvictor’s picture

astonvictor commented
StatusFileSize
new settings.png41.11 KB
new permissions.png76.07 KB
astonvictor’s picture

astonvictor commented
Assigned: astonvictor » Unassigned

Created a new MR.

I refactored the whole module to allow users to add PrevNext links to any entity type.
Tested with content, taxonomy vocabularies, and users.

It should be a new release e.g. 3.0.0

astonvictor’s picture

astonvictor commented
Title: Add submodule for taxonony terms » PrevNext for all entity types

aronne’s picture

aronne commented

@AstonVictor the issue status is still in "Needs work".
Did you forget to change it or does it really need more work?

astonvictor’s picture

astonvictor commented
Status: Needs work » Needs review

thanks
changed the status

astonvictor’s picture

astonvictor commented
Status: Needs review » Fixed

Merged to 3.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.