Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
warning: file_get_contents(themes/garland/popups-skin.js) [function.file-get-contents]: failed to open stream: No such file or directory in /home/cyberfan/htdocs/includes/locale.inc on line 1689.
Comment | File | Size | Author |
---|---|---|---|
#18 | popups_574822.patch | 937 bytes | drewish |
#13 | 574822-fix_missing_js-13.patch | 2.41 KB | HongPong |
#9 | popups-574822.2.patch | 10.33 KB | Manuel Garcia |
#7 | popups-574822.patch | 10.33 KB | Manuel Garcia |
Comments
Comment #1
dummas_324324_32 CreditAttribution: dummas_324324_32 commentedI have the same error and don`t know how to fix
Comment #2
ddffx CreditAttribution: ddffx commentedI am getting the error page not found in admin/reports/dblog, the popups module is requesting popups-skin.js from the current theme folder when Unskinned option is selected in admin/settings/popups page. The code regarding this call is in line 309 of the function popups_add_popups in popups.module file.
Quoting line 307-311
It does not make any sense why this line is for if we do not want any skin (unskinned). Also I could not find any such file (popups-skin.js) in the module directory for inclusion etc.
Any thought on this one?
Comment #3
AntiNSA CreditAttribution: AntiNSA commented???
Comment #4
altparty CreditAttribution: altparty commentedSame problem here. Just deleting the if-else construction only removes the error message. But still no content shows up.
Comment #5
awolfey CreditAttribution: awolfey commentedComment out line 309 will fix it. I'm not sure why that is there. Can maybe look more later.
Comment #6
zarudnyi CreditAttribution: zarudnyi commentedSame problem here.
Comment #7
Manuel Garcia CreditAttribution: Manuel Garcia commentedI think it is also missing a part to add the css file. In both cases it should check if the file exists already before trying to add it.
I've made a patch against the 2.x dev, and btw, 1.x branch also has this problem.
Comment #8
Manuel Garcia CreditAttribution: Manuel Garcia commentedOops, ignore the previous patch, use this one.
What I suggest is that we change that line to this:
This way if theres a css file in the current theme it also gets added, which is nice and helpful. I have tested with css file and it works great =)
Comment #9
Manuel Garcia CreditAttribution: Manuel Garcia commentedNOt my day, forgot to attach the patch
Comment #10
JGO CreditAttribution: JGO commentedIndeed, suffered from the same. Please fix!
Comment #11
JGO CreditAttribution: JGO commentedCome on, we are a year later. Just updated the module and still suffering from this problem :(
Comment #12
HongPong CreditAttribution: HongPong commentedstill the same problem here
Comment #13
HongPong CreditAttribution: HongPong commentedAlright here is another patch based on Manuel Garcia's with the same basic thing, only now it works in git with the new CVS headers out.
I really think this should be committed now. I also fixed a typo in comments.
Also I think the js should only be added, not CSS at that point? That's the difference between garcia and mine...
Comment #14
drewish CreditAttribution: drewish commentedThere's some definitely formatting issues. I'll try applying it on monday and see how it functions.
Comment #15
GiorgosKManually applied the patch (netbeans would not apply it)
and it works as expected please commit
Comment #16
JGO CreditAttribution: JGO commentedUpdated the module to beta0 and suffered again from this problem lol. How long does this take to fix ? :p
Comment #17
GiorgosK@JGO try the patch and report if it solves your problem
that is the way an issue can get resolved and get committed for the next release
right now its at the RTBC and if maintainer takes notice he will probably include it in the next release
Comment #18
drewish CreditAttribution: drewish commentedHow does this look? I committed the spelling corrections separately, stripped out the whitespace changes, and fixed the formatting.
Comment #19
jlporter CreditAttribution: jlporter commented@ #18 good patch Drewish, worked with git apply and fixed the problem. Let's get this patch applied :)
Comment #20
mattcasey CreditAttribution: mattcasey commentedThis is still an issue, thanks for the patch. It works great
Comment #21
JGO CreditAttribution: JGO commentedIndeed, the patch fixed my issues too. Please implement ;)
Comment #22
chinita7 CreditAttribution: chinita7 commented#18 fixed also my problem Thanks.
Comment #23
amaisano CreditAttribution: amaisano commentedRTBC? At least to the dev version?