Add README.txt with correct settings location [#1320068]

PMgrowl is set up and working properly on my site.

However, according to the Installation instructions:

5. Settings can be found at admin/settings/messages/pmgrowl

This is not so. However, under the Configuration -> Private Messages menu, Growl Notifications options are found.

The path for this is admin/config/messaging/privatemsg. I'm unsure that it's the same configuration set, as I cannot access admin/settings/messages/pmgrowl to compare them.

Comment	File	Size	Author
#8	add_readme-1320068-8.patch	615 bytes	sammyd56
#6	add_readme-1320068.patch	605 bytes	sammyd56

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Berdir

German

Switzerland

CreditAttribution: Berdir commented 24 October 2011 at 19:57

No, this is correct, the README.txt hasn't been updated. Can you post a patch?

Comment #2

Satori42 CreditAttribution: Satori42 commented 24 October 2011 at 21:15

I'm not sure I understand you. =)

Are you asking me to post a patch that corrects README.TXT's description of the Settings path?

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 24 October 2011 at 21:18

Issue tags:

+Novice

Exactly :)

Sounds like a perfect task for learning how to create patches and deal with git if you don't know that already.

Comment #4

Satori42 CreditAttribution: Satori42 commented 24 October 2011 at 21:34

Ah. Some other time? Such as soon when I learn development for Drupal. =)

At the moment I'm rushing to put together a huge site for an urgent purpose. Wanted to be sure to take a moment to post feedback for the module developers as I encountered errors though.

Additionally, just patching files within Windows 7 is hit-or-miss. Most of the applications for patching on Windows aren't functioning properly in the x64 architecture.

I appreciate the thought, though.

Comment #5

a_lawry CreditAttribution: a_lawry commented 23 November 2011 at 01:38

I can't see the README.txt in 7.x-1.x-dev? I'm happy to make the patch.

Comment #6

sammyd56 CreditAttribution: sammyd56 commented 27 November 2011 at 14:07

Title:	Settings page not found.	» Add README.txt with correct settings location
Category:	bug	» task
Status:	Active	» Needs review

File	Size
add_readme-1320068.patch	605 bytes

My first patch! Hope it's OK...

Comment #7

Berdir

German

Switzerland

CreditAttribution: Berdir commented 27 November 2011 at 20:58

Status:

Needs review

» Needs work

Patch itself is correct, two remaining issues below.

+++ b/README.txtundefined
@@ -0,0 +1,8 @@
+1. Download and extract this module and privatemsg module into your modules directory

.. download this and the privatemsg module...

+++ b/README.txtundefined
@@ -0,0 +1,8 @@
+2. Download the Growl plugin from http://www.stanlemon.net/projects/jgrowl.html and extract it inside of the pmgrowl module directory.
+3. Make sure that the jquery.jgrowl.css, and the jquery.jgrowl_minimized.js files are both directly inside of the pmgrowl/jgrowl directory.
+4. Enable the module
+5. Settings can be found at admin/config/messaging/privatemsg

Make sure that you wrap the lines at 80 characters, makes it easier to read in a console or another place where you have a limited/fixed width.

Powered by Dreditor.

Comment #8

sammyd56 CreditAttribution: sammyd56 commented 27 November 2011 at 21:23

File	Size
add_readme-1320068-8.patch	615 bytes

OK, here's a second attempt :)

Comment #9

sammyd56 CreditAttribution: sammyd56 commented 27 November 2011 at 21:23

Status:

Needs work

» Needs review

Comment #10

diwant CreditAttribution: diwant commented 28 November 2011 at 19:12

Status:

Needs review

» Reviewed & tested by the community

I ran the patch. Works fine, creates the new README.txt. There are other problems the coder module points out, but this patch works as expected and within guidelines.