Running a fresh RC2 and today's dev version, got this error immediately after enabling the module:

Fatal error: Call to undefined function url() in /xyz/modules/plupload/plupload.install on line 29

CommentFileSizeAuthor
#2 plupload.inmediate_crash_on_install_without_plupload_library-2607680-2.patch493 bytesbudalokko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Todd Young created an issue. See original summary.

budalokko’s picture

budalokko CreditAttribution: budalokko as a volunteer commented
Status: Active » Needs review
FileSize
plupload.inmediate_crash_on_install_without_plupload_library-2607680-2.patch493 bytes

Thank you for taking the time to test the module.

Attached patch solves the problem, which happens when plupload library has not been downloaded yet in libraries directory.

The patch removes an url() call and puts directly an external URL (picked from plupload.libraries.yml) on a message for the user. Instead of this, the url() call could be replaced by

\Drupal\Core\Url::fromUri($library['website'])->toString(),

but I am unable to see any validation on the URL when doing this, so it seems unnecessary. Also some lines below, we do something similar with another URL and the URL is placed as is too.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Status: Needs review » Fixed

Committed! Thanks.

  • slashrsm committed fb3b1e0 on 8.x-1.x authored by budalokko 
    Issue #2607680 by budalokko: Immediate crash on install with Nov 3rd dev...
Todd Young’s picture

Todd Young CreditAttribution: Todd Young commented
Status: Fixed » Closed (fixed)

Closing as fixed. Thanks!