The newly released Drupal 7.23 release breaks the integration with plupload. It is still possible to select 'advanced upload' and drop images onto it to upload, but after uploading instead of displaying the individual images you get a second upload selector and a weight selection. I've attached screenshots to demonstrate what I mean.

Downgrading back to 7.22 works as temporary work-around.

CommentFileSizeAuthor
#15 2063161-plupload-id-14.patch573 byteshefox
#5 plupload.module.patch563 bytesmfgering
failure.png28.22 KBAmon_Re
multi uploads.png29.25 KBAmon_Re
begin.png17.83 KBAmon_Re
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drclaw’s picture

drclaw CreditAttribution: drclaw commented

I can confirm this issue...

Greenman77’s picture

Greenman77 CreditAttribution: Greenman77 commented

Also confirmed recent upgrade to Drupal 7.23 seems to break PLUpload. Symptoms exactly as Amon_Re has detailed.

oboz’s picture

oboz CreditAttribution: oboz commented

Confirm this. Now no ideas...

mfgering’s picture

mfgering CreditAttribution: mfgering commented

Not sure what the cause is yet, but I can see that the code in plupload.module:121 is not finding its form elements. It is trying to match an element id, e.g. edit-upload-und-0-filefield-plupload-pud--2, to values that look like "edit-upload-und-0-filefield-plupload-pud_0_tmpname". The element id has "--2" appended where the regular expression is not expecting it, in this example.

I created a patch that works so far for me.

mfgering’s picture

mfgering CreditAttribution: mfgering commented
FileSize
plupload.module.patch563 bytes

This patch changes the way the plupload module looks for form elements. It excludes a uniqueness component of the element id that Drupal puts in to support ajax.

NitraM’s picture

NitraM CreditAttribution: NitraM commented

mfgering your patch at #5 works for me! Thanks

Amon_Re’s picture

Amon_Re CreditAttribution: Amon_Re commented

Patch seems to work here too. Running it on my staging site atm.

atlea’s picture

atlea CreditAttribution: atlea commented
Project: FileField Sources Plupload » Plupload integration
icampana’s picture

icampana
Primary language Spanish
CreditAttribution: icampana commented
Status: Active » Reviewed & tested by the community

I tested this patch in a big site and works perfectly, thanks a lot!

oboz’s picture

oboz CreditAttribution: oboz commented

mfgering, Thank you very much!!!

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed. I'll rolll new release shortly.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tea.time’s picture

tea.time CreditAttribution: tea.time commented

Marked #1841868: AJAX submits -- plupload_element_value()'s use of $element['#id'] breaks due to drupal_html_id() incrementation as duplicate.

  • Commit 762ae29 on 7.x-1.x, 8.x-1.x authored by mfgering, committed by slashrsm: 
    Issue #2063161 by mfgering | Amon_Re: Fixed Multi Upload with plupload...
hefox’s picture

hefox CreditAttribution: hefox commented
Issue summary: View changes
FileSize
2063161-plupload-id-14.patch573 bytes

Patch against 1.0 for use in make files