Add damiankloip as a co maintainer? [#1823180]

Comment #1

bleen CreditAttribution: bleen commented 26 October 2012 at 19:49

Status:

Needs review

» Postponed (maintainer needs more info)

As long as you agree that the goal of this module is only to backfill browser compatibility for those browsers that do not support the HTML5 "placeholder" property then I am ok with this.

Sound ok?

(FYI: needs review is actually the correct status)

Log in or register to post comments

Comment #2

damiankloip CreditAttribution: damiankloip commented 26 October 2012 at 20:00

Yes, that sounds fine to me :)

Following in the steps on the 6.x module; providing the element '#placeholder' key and the processing to add the placeholder library.

'Needs review' should usually only be used when a patch is present I think ....

Log in or register to post comments

Comment #3

damiankloip CreditAttribution: damiankloip commented 26 October 2012 at 20:01

Status:

Postponed (maintainer needs more info)

» Active

Let's go with active.

Log in or register to post comments

Comment #4

bleen CreditAttribution: bleen commented 27 October 2012 at 01:03

Status:

Active

» Fixed

by the power vested in me....

Log in or register to post comments

Comment #5

damiankloip CreditAttribution: damiankloip commented 29 October 2012 at 10:29

Status:

Fixed

» Active

Not sure if I have any commit access yet? You can review some code first it you like, I don't mind :)

Log in or register to post comments

Comment #6

bleen CreditAttribution: bleen commented 29 October 2012 at 12:10

You do have access ... just make sure you use the issue queue normally before committing anything. Give people (including me) some opportunity to comment on patches before you commit them. If no one responds after a few days then go for it...