Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#8 | pki_ra-allow_email_text_alterations-2946001-8.patch | 1.86 KB | colan |
#5 | interdiff-2946001-1-5.txt | 1 KB | umed91 |
#5 | custom_hook_2946001_5.patch | 1.79 KB | umed91 |
#2 | custom_hook_2946001_1.patch | 1.48 KB | umed91 |
Comments
Comment #2
umed91 CreditAttribution: umed91 commentedAttached patch will add a alter hook which can be used to alter the email verification text.
Comment #3
umed91 CreditAttribution: umed91 commentedComment #4
colanMissing a "." at the end.
Missing variable type and a 2-space indented description on the next line. What's the structure of the variable? Developers need to know this.
Needs a blank line separating the @params and @return.
Also, a 2-space indented description is missing on the next line. I don't really feel a description adds much here, but it's the d.o coding standards.
Would be good to provide an example of setting $parameters here.
Comment #5
umed91 CreditAttribution: umed91 commentedCode review changes are updated in the attached patch file and interdiff file is attached.
Comment #7
colanThanks, looks great.
Comment #8
colanSorry I didn't catch this earlier, but the hook name should include the module ID so that's it's obvious what module is providing it, like we're doing with the other hooks here.
Comment #10
colan