Change to page template for site slogan [#2769871]

The 7.x-3.1 release altered to page template (templates/page.tpl.php) for site-slogan. Instead of <h2 id="site-slogan"> we now have <p id="site-slogan">.

This is really not the sort of change that can safely be made once a theme is in use on live sites. It has created two problems:

All our CSS code with rules like "h2#site-slogan" has stopped working.
THEME_fonts.css has stopped working as adaptivetheme/at_core/inc/fonts.inc still refers to h2#site-slogan.

Given that at_core page template still uses h2, then it seems like the correct fix is to revert pixture_reloaded to use h2 to match.

Our live sites are currently degraded, so we would appreciate an urgent fix please. We do have paid support at http://adaptivethemes.com/. However we raised the issue here, because the support tracker on your own site seems to only allow issues to be raised against the paid themes.

Comment	File	Size	Author
#5	0001-Issue-2769871-Change-to-page-template-for-site-sloga.patch	1.15 KB	Jeff Burnz

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 July 2016 at 12:35

AdamPS created an issue. See original summary.

Comment #2

AdamPS CreditAttribution: AdamPS commented 20 July 2016 at 12:56

Issue summary:

View changes

Comment #3

Jeff Burnz CreditAttribution: Jeff Burnz commented 20 July 2016 at 21:45

Agreed, my apologies, that looks like a bad commit i.e. that never should have been like that.

Lets roll that back.

Comment #4

20 July 2016 at 21:50

Jeff Burnz committed afbef23 on 7.x-3.x

Issue #2769871: Change to page template for site slogan

Comment #5

Jeff Burnz CreditAttribution: Jeff Burnz commented 20 July 2016 at 21:50

File	Size
0001-Issue-2769871-Change-to-page-template-for-site-sloga.patch	1.15 KB

Patch plus this is pushed to DEV, will cut a new release later in the day.

Comment #6

AdamPS CreditAttribution: AdamPS commented 21 July 2016 at 10:39

Thanks for a very quick response.

I see your patch has added back in id="site-name" and id="site-slogan". These are not present in the base theme, and as far as I can tell not necessary due to code in adaptivetheme\at_core\inc\preprocess.inc like this $vars['site_slogan_attributes_array']['id'][] = 'site-slogan';. I've not yet had a chance to test whether there is any harm from the double setting, but probably clearer and more consistent with other sub-themes to leave it off.